refactor: use a single client assertion audience #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 57 57
Lines 11276 11276
=======================================
Hits 10782 10782
Misses 373 373
Partials 121 121 ☔ View full report in Codecov by Sentry. |
developerkunal
force-pushed
the
use-single-jwtca-audience
branch
from
f6cf2c1 to
d1e5865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align with FAPI 2.0 and future client assertion requirements this changes the JWT Client Authentication assertion to use a single audience string value. The value itself is the issuer identifier.