Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BrandingPhoneProvider: Replace MarshalJSON with reset Method #514

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

developerkunal
Copy link
Contributor

🔧 Changes

  • Replaced MarshalJSON method with a reset method for BrandingPhoneProvider
  • Removed custom JSON marshaling logic, as it is no longer needed
  • Added a reset function to clear specific fields (ID, Channel, Tenant)

📚 References

N/A

🔬 Testing

  • Verified that reset correctly clears the required fields
  • Ensured no regressions in existing behavior related to BrandingPhoneProvider
  • Ran unit tests to confirm expected behavior

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@developerkunal developerkunal requested a review from a team as a code owner February 24, 2025 07:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (59f33dd) to head (0a1e74d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
- Coverage   95.61%   95.61%   -0.01%     
==========================================
  Files          57       57              
  Lines       11276    11269       -7     
==========================================
- Hits        10782    10775       -7     
  Misses        373      373              
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@developerkunal developerkunal merged commit b9b9b35 into main Feb 24, 2025
7 checks passed
@developerkunal developerkunal deleted the remove-unmarshell-for-branding-phone-provider branch February 24, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants