-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Federated connections #1879
base: v4-backup
Are you sure you want to change the base?
Conversation
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ensure we test that this works fine in all cases (Server Component, Pages, App, ...), both for access tokens and federated connection access tokens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, will ensure this works across all cases. Will also update unit tests.
simplify session stores, add documentation FCAT implementation update remove readonly qualifiers remove extra docs from abstract session store revert stateful session store changes remove use of audience for caching FCATs, add wrapper method in auth-clint.ts to avoid passing this.clientAuth callback to federatedConnectionsTokenExchange and instead pass a concrete value; linting fixes; remove redundant code as pointed out in review revert uses of nullish coalescing operator move existing tokenset check logic to within exchange code fix: compilation issues fix: ensure we await setSessionStore fix: decrypt cookie using secret fix: return undefined from findFederatedToken when no token in cache fix: ensure token expiresAt is checked correctly linting changes changed field and method names to be more descriptive improved jsdocs
fe42912
to
54b17fe
Compare
WIP
Please see comments below