Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to protobuf v5 #154

Merged
merged 1 commit into from
May 1, 2024
Merged

Update to protobuf v5 #154

merged 1 commit into from
May 1, 2024

Conversation

intentionally-left-nil
Copy link
Contributor

@intentionally-left-nil intentionally-left-nil commented May 1, 2024 •
edited
Loading

Fixes #113

Per https://protobuf.dev/support/cross-version-runtime-guarantee/,

protobuf needs to be generated, and run on the same major version. The codegen here is using 5.26 (see e.g. this snippet all over the tree)

# -*- coding: utf-8 -*-
# Generated by the protocol buffer compiler.  DO NOT EDIT!
# source: authzed/api/v1/core.proto
# Protobuf Python Version: 5.26.1

so the runtime dependencies also should match 5.26

@intentionally-left-nil intentionally-left-nil requested a review from a team May 1, 2024 20:58
josephschorr
josephschorr approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr added this pull request to the merge queue May 1, 2024
Merged via the queue into authzed:main with commit 9a1c9a4 May 1, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump upper bound of protobuf dependencies
2 participants
@intentionally-left-nil @josephschorr