Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to toggle off specific warnings via magic comments #1984

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add ability to toggle off specific warnings via magic comments #1984

merged 1 commit into from
Jul 11, 2024

Conversation

josephschorr
Copy link
Member

@josephschorr josephschorr commented Jul 11, 2024 •
edited
Loading

Example:

definition test {
  // spicedb-ignore-warning: permission-references-itself
  permission view = view	
}

Fixes #1975

@josephschorr josephschorr requested a review from a team as a code owner July 11, 2024 21:40
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jul 11, 2024
alecmerdler
alecmerdler previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@josephschorr josephschorr added this pull request to the merge queue Jul 11, 2024
Merged via the queue into authzed:main with commit da17bbf Jul 11, 2024
22 checks passed
@josephschorr josephschorr deleted the ignore-warnings branch July 11, 2024 22:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alecmerdler alecmerdler alecmerdler approved these changes

Assignees
No one assigned
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to toggle certain schema warnings off
2 participants
@josephschorr @alecmerdler