Added expiration functionality to relationship writing #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Please separate out tests that make assertions about expiration behavior and leave the existing tests as they are.
internal/commands/relationship.go
Outdated
Comment on lines
494
to
504
| if err := handleCaveatFlag(cmd, rel); err != nil { | ||
| if err := handleCaveatAndExpirationFlags(cmd, rel); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I'd prefer to handle the different flags inline here - remove handleCaveatAndExpirationFlags and have a separate if statement here for handleExpiration.
kartikaysaxena
force-pushed
the
expiration-time-flag
branch
2 times, most recently
from
15ee98a to
cdbd4d6
Compare
|
It seems like there are some vulnerabilities with version of Go in goreleaser which trivy is complaining while analysing the built images Edit: Failing on https://github.com/authzed/zed/actions/runs/13012923194/job/36294786430?pr=456 too |
Signed-off-by: Kartikay <[email protected]>
kartikaysaxena
force-pushed
the
expiration-time-flag
branch
from
ba7e96e to
556a947
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #448 added a flag
--expiration-timeto take the input timestamp in RFC 3339 format, also added tests.