Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed workflow #466

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

kartikaysaxena
Copy link
Contributor

Related #464
Fixed workflow, tested on fork, example PR kartikaysaxena/docs#1
The token should have read/write permissions

tstirrat15

This comment was marked as outdated.

Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment - otherwise it's looking good to me.

Comment on lines 65 to 53
gh pr create \
--body "" \
--title "docs: update zed docs" \
--head "update-generated-docs" \
--base "main"
else
echo "No changes detected in $TARGET_DOCS_FILE."
echo "CHANGES_DETECTED=false" >> $GITHUB_ENV
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah did have a look over the documentation, kartikaysaxena/docs#2 was the result of changes, switching to this action.

@kartikaysaxena kartikaysaxena force-pushed the docs/workflow branch 2 times, most recently from d403ce1 to 78bb72b Compare February 7, 2025 21:14
Signed-off-by: Kartikay <[email protected]>
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this looks good!

@tstirrat15 tstirrat15 merged commit b2fb87b into authzed:main Feb 10, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
@tstirrat15
Copy link
Contributor

There was a perms failure: https://github.com/authzed/zed/actions/runs/13243163183/job/36963066495

I think there might be something about a PAT or the permissions on the token declared at the top of the file? I'm curious as to why it worked in your fork but not here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants