remove host volume mount for recordings

autobashcraft · Dec 30, 2023 · 816417f · 816417f
1 parent 85277b8
commit 816417f
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 2 deletions.
diff --git a/examples/exec_test/assets/exec_test_1.gif b/examples/exec_test/assets/exec_test_1.gif
diff --git a/examples/save_test/assets/save_test_1.gif b/examples/save_test/assets/save_test_1.gif
diff --git a/examples/save_test/assets/save_test_3.gif b/examples/save_test/assets/save_test_3.gif
diff --git a/examples/save_test/assets/save_test_6.gif b/examples/save_test/assets/save_test_6.gif
diff --git a/examples/save_test/assets/save_test_8.gif b/examples/save_test/assets/save_test_8.gif
diff --git a/src/executeCommands.ts b/src/executeCommands.ts
@@ -129,7 +129,11 @@ const initializeRuntime = async (options: { baseImage?: string }) => {
   await stopTmpContainer();
 
   // start the runtime container
-  const containerStartCmd = `docker run ${dockerSockVolume} --group-add docker --group-add sudo --network host -dit --rm --user ${uid}:${gid} -v ${workspacePath}:${workspacePath} ${baseImage}`;
+  const containerStartCmd = `docker run ${dockerSockVolume} --group-add docker --group-add sudo --network host \
+  -dit --rm --user ${uid}:${gid} \
+  -v ${recordingPath} \
+  -v ${workspacePath}:${workspacePath} \
+  ${baseImage}`;
   const startResult = await execProm(containerStartCmd);
   containerId = startResult.stdout.trim();
   log(
@@ -270,7 +274,7 @@ export async function executeCommands({
           // create a gif of the recorded asciinema cast (better switch to agg)
           log(
             await execProm(
-              `docker run --user ${uid}:${gid} --rm -v ${recordingPath}:/data asciinema2/asciicast2gif -s ${config.asciinema.speed} -t monokai /data/${castFilename}.cast /data/${castFilename}.gif`
+              `docker run --user ${uid}:${gid} --rm --volumes-from ${containerId} asciinema2/asciicast2gif -s ${config.asciinema.speed} -t monokai ${recordingPath}/${castFilename}.cast ${recordingPath}/${castFilename}.gif`
             )
           );
           // remove the asciinema .cast file (maybe we should use it)