Skip to content

Commit

Permalink
Merge branch 'release/0.0.6'.
Browse files Browse the repository at this point in the history
  • Loading branch information
petrbroz committed Aug 14, 2023
2 parents e4b4353 + cff3a21 commit 40fc867
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion connectors/aps-props-connector/DesignPropsConnector.pq
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[Version = "0.0.5"]
[Version = "0.0.6"]
section DesignPropsConnector;

SECRETS = Json.Document(Extension.Contents("secrets.json"));
Expand Down
2 changes: 1 addition & 1 deletion services/aps-shares-app/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "aps-shares-app",
"description": "Simple web application providing public access to selected designs in Autodesk Platform Services.",
"version": "0.0.5",
"version": "0.0.6",
"main": "index.js",
"scripts": {
"start": "node index.js"
Expand Down
4 changes: 2 additions & 2 deletions visuals/aps-viewer-visual/pbiviz.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"visual": {
"name": "aps-viewer-visual",
"displayName": "APS Viewer Visual (0.0.5)",
"displayName": "APS Viewer Visual (0.0.6)",
"guid": "aps_viewer_visual_a4f2990a03324cf79eb44f982719df44",
"visualClassName": "Visual",
"version": "0.0.5",
"version": "0.0.6",
"description": "Visual for displaying shared 2D/3D designs from Autodesk Platform Services.",
"supportUrl": "https://github.com/autodesk-platform-services/aps-powerbi-tools",
"gitHubUrl": "https://github.com/autodesk-platform-services/aps-powerbi-tools"
Expand Down
2 changes: 1 addition & 1 deletion visuals/aps-viewer-visual/src/viewer.utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function initializeViewerRuntime(options: Autodesk.Viewing.InitializerOpt
await loadScript('https://developer.api.autodesk.com/modelderivative/v2/viewers/7.*/viewer3D.js');
await loadStylesheet('https://developer.api.autodesk.com/modelderivative/v2/viewers/7.*/style.css');
return new Promise((resolve, reject) => Autodesk.Viewing.Initializer(runtime.options, resolve));
})();
})() as Promise<void>;
} else {
if (['accessToken', 'getAccessToken', 'env', 'api', 'language'].some(prop => options[prop] !== runtime.options[prop])) {
return Promise.reject('Cannot initialize another viewer runtime with different settings.');
Expand Down
8 changes: 4 additions & 4 deletions visuals/aps-viewer-visual/src/visual.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ export class Visual implements IVisual {
}

if (this.viewer && this.idMapping && this.currentDataView) {
const externalIds = this.currentDataView.table?.rows;
const externalIds = this.currentDataView.table.rows || [];
//@ts-ignore
const isDataFilterApplied = this.currentDataView.metadata?.isDataFilterApplied;
if (externalIds?.length > 0 && isDataFilterApplied) {
const isDataFilterApplied = this.currentDataView.metadata && this.currentDataView.metadata.isDataFilterApplied;
if (externalIds.length > 0 && isDataFilterApplied) {
//@ts-ignore
const dbids = await this.idMapping.getDbids(externalIds);
this.viewer.isolate(dbids);
Expand Down Expand Up @@ -186,7 +186,7 @@ export class Visual implements IVisual {
}

private async onSelectionChanged() {
const allExternalIds = this.currentDataView?.table?.rows;
const allExternalIds = this.currentDataView.table.rows;
if (!allExternalIds) {
return;
}
Expand Down

0 comments on commit 40fc867

Please sign in to comment.