Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature (New SDk) #21

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feature (New SDk) #21

wants to merge 4 commits into from

Conversation

Arrotech
Copy link

What does this PR do?

Migrate the simple viewer tutorial to use the new sdk

@petrbroz
Copy link
Member

Thank you @Arrotech. I'm reviewing this PR now. Btw I'm not going to merge this one directly because it still contains lots of ballast (hundreds of files being removed and added) but I'm creating a new branch based on your changes.

One thing I've noticed is that there's a lots of debug logs output to console when using the new SDKs, e.g.:

Server listening on port 8080...
info: 22-02-2024 10:45:54:      Entered into fetchtoken 
info: 22-02-2024 10:45:54:      fetchtoken Request completed successfully with status code: 200
info: 22-02-2024 10:45:54:      Entered into fetchtoken 
info: 22-02-2024 10:45:54:      fetchtoken Request completed successfully with status code: 200
info: 22-02-2024 10:45:54:      Entered into getBucketDetails 
info: 22-02-2024 10:45:55:      getBucketDetails Request completed successfully with status code: 200
info: 22-02-2024 10:45:55:      Entered into fetchtoken 
info: 22-02-2024 10:45:55:      fetchtoken Request completed successfully with status code: 200
info: 22-02-2024 10:45:55:      Entered into getObjects 
info: 22-02-2024 10:45:56:      getObjects Request completed successfully with status code: 200
info: 22-02-2024 10:45:56:      Entered into getObjects 
info: 22-02-2024 10:45:56:      getObjects Request completed successfully with status code: 200
info: 22-02-2024 10:45:56:      Entered into fetchtoken 
info: 22-02-2024 10:45:57:      fetchtoken Request completed successfully with status code: 200
info: 22-02-2024 10:45:57:      Entered into getManifest 
info: 22-02-2024 10:45:57:      getManifest Request completed successfully with status code: 200

Is that intentional?

@petrbroz
Copy link
Member

petrbroz commented Feb 22, 2024

Also, it looks like the upload functionality might be broken. When uploading a Revit file, the upload process seems to have finished successfully, but when trying to translate the design, I get the following error:

Screenshot 2024-02-22 at 10 53 30

EDIT:

After some more investigation, it looks like the uploaded file is missing 1 byte. On my local filesystem the Revit file has 6344704 bytes, but in the OSS bucket it has 6344703 bytes.

@petrbroz
Copy link
Member

Btw the simplified version of this PR is tracked in https://github.com/autodesk-platform-services/aps-simple-viewer-nodejs/tree/new-sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants