-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated sdk #24
base: develop
Are you sure you want to change the base?
Updated sdk #24
Conversation
Why are we bundling the SDKs in the codebase instead of installing them from NPM? Please note that the develop branch is referred to by https://tutorials.autodesk.io, so any changes here would have to be reflected in the tutorial as well, and I don't think the tutorial should be asking people to embed the SDKs this way. |
@petrbroz - We are yet to release the updated packages to npm. This pr is for first review & feedback to confirm all looks good. Once done, we will proceed to publish the updated packages and update this pr and remove local references. |
Thanks for the clarification Sajith. Again, since this code is just for an internal review, there's no need to create a PR for the develop branch. Feel free to just create a test branch (either here or in your own fork), and share it with anyone who should review the code. |
Sure, thanks Petr. Will create test branch for future updates. |
Oops!I had always assumed that the validity period of my account in the Aps Viewer module had expired, and I've been trying various other way to address the issue of converting files for web use. It's been quite a frustrating journey, but today, as I was reorganizing my code, I decided to give the old code one last shot,I realized that it wasn't my account that was restricted, but rather the SDK that had been upgraded. Now I need to retest everything based on the new version. |
Yes, @petrbroz, you're right. We should use the new version by installing the npm package. This time, I'll first refer to the code provided by Mr. srivastavarahull. By the way, I found several tutorials on the official website not very user-friendly. I tried the step-by-step approach and the native Html+JS route, following the tutorials step by step, but both failed at the svf conversion step, always ending in failure. Fortunately, I later discovered this repository, and it worked on the first try. Thanks to the repository author and also to Mr. @srivastavarahull for his personal insights on the new version. |
Updated viewer with the new sdk version