-
Notifications
You must be signed in to change notification settings - Fork 2
feat(UI-1898): datadog screen session replays #1333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/constants/index.ts
Outdated
| export { getBillingPlanFeatures } from "@constants/lists"; | ||
| export { billingUpgradeFetchUrlRetries } from "@src/constants/billing.constants"; | ||
| export { lintViolationRules } from "@constants/project.constants"; | ||
| export { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of re exporting here all the constant?
You use Datadog constant directly below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored
src/hooks/useProjectActions.tsx
Outdated
| projectId, | ||
| projectName: name, | ||
| }); | ||
| DatadogUtils.trackEvent("project_created", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of Datadog util
Call is user tracking util
And abstract datadog / clarity / other stuff we might try in the future
That way you don't have to change it in many places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/main.tsx
Outdated
|
|
||
| TimeAgo.addDefaultLocale(en); | ||
|
|
||
| if (!applicationId || !clientToken || !datadogVersion) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the only place you use this constants, why you need to define them in another file and export them through a third file just for one place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 💪🏼 ! We centralize all constants in src/constants to maintain consistency with our project structure and ensure easy discoverability, even if currently used in only one place.
9b26aec to
5f9c2dd
Compare
src/hooks/useUserTracking.ts
Outdated
| const isClarityInitialized = window.clarity && isProduction && msClarityId; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about datadog?
didn't you expose it as userTracking and hide both clarity and datadog?
|
🎉 This release is now available on GitHub |
Description
The integration provides comprehensive monitoring of user interactions, performance metrics, and session recordings.
Linear Ticket
https://linear.app/autokitteh/issue/UI-1898/datadog-browser-session-recordings
What type of PR is this? (check all applicable)