-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump phusion base image from Ubuntu 20.04 (focal) to Ubuntu 22.04 (jammy) #331
Bump phusion base image from Ubuntu 20.04 (focal) to Ubuntu 22.04 (jammy) #331
Conversation
Ubuntu 22.04 comes with Error on ancient 20.04:
Output on new (still old) 22.04:
|
@makuser tested this locally building the image and then rolling into arm causes the web UI to crash ...
Starting web ui
Traceback (most recent call last):
File "/opt/arm/arm/runui.py", line 8, in <module>
import arm.config.config as cfg # noqa E402
File "/opt/arm/arm/../arm/__init__.py", line 2, in <module>
import arm.ripper
File "/opt/arm/arm/../arm/ripper/__init__.py", line 3, in <module>
from arm.ripper import logger, utils, makemkv, handbrake, identify, ARMInfo # noqa F401
File "/opt/arm/arm/../arm/ripper/utils.py", line 24, in <module>
from arm.ui import db # needs to be imported before models
File "/opt/arm/arm/../arm/ui/__init__.py", line 11, in <module>
from flask_wtf import CSRFProtect
File "/usr/local/lib/python3.10/dist-packages/flask_wtf/__init__.py", line 4, in <module>
from .recaptcha import Recaptcha
File "/usr/local/lib/python3.10/dist-packages/flask_wtf/recaptcha/__init__.py", line 1, in <module>
from .fields import RecaptchaField
File "/usr/local/lib/python3.10/dist-packages/flask_wtf/recaptcha/fields.py", line 3, in <module>
from . import widgets
File "/usr/local/lib/python3.10/dist-packages/flask_wtf/recaptcha/widgets.py", line 3, in <module>
from werkzeug.urls import url_encode
ImportError: cannot import name 'url_encode' from 'werkzeug.urls' (/usr/local/lib/python3.10/dist-packages/werkzeug/urls.py) This is resolvable, but will require additional changes to merge this PR and changes to the web UI. |
I can not reproduce this here, when did it crash, which action did you perform? It starts up just nicely and works, I already ran a full cycle of one DVD with this setup now.
Maybe check out this, if that does not work for you, then your python packages are not installed properly. You should be able to import
|
Issue was an out of date dependencies branch on my test machine :( Tested and can confirm works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed resolves makemkv issue
Confirmed works, will merge once github docker build runs and confirms no issues |
63de72d
into
automatic-ripping-machine:main
Fixes automatic-ripping-machine/automatic-ripping-machine#1195
Fixes #330