-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dolby Vision support to HandBrake #346
Add Dolby Vision support to HandBrake #346
Conversation
Can you load a build log showing it all built and passing |
https://github.com/Church13/arm-dependencies-libdovi/actions/runs/11984526487 Here's the build log from the PR merge on my fork. Ended up doing a refactor and putting everything in the Since I had to go back and forth with changes in these commits I'd recommend a squashed merge to flatten it down in the git history. And here's a log of the container successfully running HandBrakeCLI in the built image on a file with Dolby Vision!
|
Thanks for linking to your fork and logs Didn't want to run the job if it hadn't passed on your machine or fork. What size is the dependencies image now? |
Will merge this branch once the Docker Job passes |
It's now back to 2.62GB, same as the 1.2.0 version! Was up to 4.2GB before I caught that rustup hadn't been fully cleaned up. |
30e213f
into
automatic-ripping-machine:main
The version of HandBrake built for ARM does not include Dolby Vision support. This PR implements build-deps and adds the necessary compiler configuration flag to support Dolby Vision through the libdovi library.
Dolby Vision is becoming an increasingly common HDR format for 4K/UHD Blu-Ray content, and ARM should support retaining Dolby Vision HDR metadata. Currently, without HandBrake built for Dolby Vision support, transcoding falls back to HDR10+ or HDR.
HandBrake requires rustup, cargoc and associated dependencies to be able to use the
--enable-libdovi
build flag, enabling Dolby Vision support with the x265 encoder when using 10-bit.