Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(websocket): ProtocolV1 shouldn't be exported as type because it's a string #353

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(websocket): ProtocolV1 shouldn't be exported as type because it's a string #353

merged 1 commit into from
Jul 23, 2024

Conversation

yurijmikhalevich
Copy link
Contributor

@yurijmikhalevich yurijmikhalevich commented May 25, 2024 •
edited
Loading

Hi everyone! :) Thank you for the great project.

I have noticed that the example WebSocket code doesn't work with ProtocolV1 being exported as type:
image

This PR fixes that.

@pvh pvh merged commit b820796 into automerge:main Jul 23, 2024
2 checks passed
@pvh
Copy link
Member

pvh commented Jul 23, 2024

Thank you! Good catch.

@yurijmikhalevich
Copy link
Contributor Author

@pvh, thank you and the team for the great library 🔥

@yurijmikhalevich yurijmikhalevich deleted the fix/websocket-types branch July 24, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvh pvh pvh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurijmikhalevich @pvh