Fix: support Bun runtime in the core library #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bun runtime (built on JSC) does not expose the Error stack trace modification features that we tap into V8. This update adds defensive code to check for it and if the "prepareStackTrace" doesn't exist, it will resort to an earlier version of manual stack trace parsing to find the module for the function
…situation and ensure the module is reported consistently
keturiosakys
force-pushed
the
bun-runtime
branch
from
62e5388
to
4998487
Compare
arendjr
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses #112 issue that made the library unusable in the Bun runtime.
Unlike Node/Deno (built on V8), Bun runtime (built on JSC) does not expose the Error stack trace modification features that we tap into to more reliably find the module for the autometrics-wrapped function. This update adds defensive code to check for it and if the
prepareStackTracedoesn't exist, it will resort to an earlier version of manual stack trace parsing to find the module for the function.It also updates the test for utilities to ensure it can consistenly run with our main test engine
vitestand updates the script to run the test inbunas well.