Adding in CPU time to wherever time is defined as variable "cpu_time" #1173

thijssnelleman · 2024-11-26T14:08:44Z

Changed the TrialValue to hold CPU time and have SMBO use this value to calculate its budgets

Same behaviour as the original 'time' variable, except in its calculation tries to estimate CPU time with process_time instead.
Added in to TrialValue object, RunHistory and SMBO so it can be recorded and correctly calculate the remaining CPU budget

Pytest are passing (on my machine)

benjamc

is there any way to test the new cpu return? if yes, please add a little test

otherwise, codewise the PR LGTM, it only needs a bit more documentation.
You can basically copy/paste the description for cpu_time everywhere.

CHANGELOG.md

smac/main/smbo.py

smac/runhistory/dataclasses.py

smac/runhistory/runhistory.py

smac/runner/target_function_runner.py

smac/runner/abstract_runner.py

smac/runner/target_function_script_runner.py

thijssnelleman · 2024-11-29T10:49:10Z

Added in CPU time tests in target function runner tests

Adding in CPU time to wherever time is defined as variable "cpu_time"

4487692

benjamc requested changes Nov 27, 2024

View reviewed changes

benjamc self-assigned this Nov 27, 2024

benjamc added this to the v2.3 milestone Nov 27, 2024

benjamc mentioned this pull request Nov 27, 2024

SMAC time budget walltime vs CPU time #1159

Closed

thijssnelleman added 4 commits November 29, 2024 11:28

Fix changelog

6814157

Updating comments as requested in PR

ac0a09b

Forgot to update comment

2b8072f

Adding in CPU time tests

f3de009

thijssnelleman requested a review from benjamc November 29, 2024 10:49

benjamc approved these changes Nov 29, 2024

View reviewed changes

benjamc merged commit 000dd2d into automl:development Nov 29, 2024
11 checks passed

Provide feedback