Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folder download to frontend #32

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

clostao
Copy link
Collaborator

@clostao clostao commented Oct 1, 2024

Added folder download to frontend and couple small fixes

@clostao clostao added this to the Auto Drive PoC milestone Oct 1, 2024
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for auto-drive-demo ready!

Name Link
🔨 Latest commit 293d55e
🔍 Latest deploy log https://app.netlify.com/sites/auto-drive-demo/deploys/66fd085209c7a20008b985d8
😎 Deploy Preview https://deploy-preview-32--auto-drive-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@clostao
Copy link
Collaborator Author

clostao commented Oct 1, 2024

Solves: #5

@@ -16,7 +16,7 @@ export default function App() {
// These are example parameters. Replace with your actual values
const params = new URLSearchParams({
client_id: process.env.NEXT_PUBLIC_GOOGLE_AUTH_CLIENT_ID!,
redirect_uri: "http://localhost:8080/api/auth/callback/google",
redirect_uri: `${window.location.origin}/api/auth/callback/google`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to make it a blocker, if this work, this is fine with me.
But since next-auth is setup, why not simply using signIn('google') from next-auth when clicking on the google signin button?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, much cleaner solution

@clostao clostao merged commit 6eb38e4 into main Oct 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants