Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils to auto-utils, auto-id packages. #21

Closed
wants to merge 4 commits into from
Closed

Conversation

abhi3700
Copy link
Contributor

@abhi3700 abhi3700 commented Jun 10, 2024

Fixes #15

This PR is to add the functions, classes from auto-kit's utils.py, test_utils.py (written in Python) to TypeScript code.

Added:

  • AlgorithmIdentifier, derEncodeSignatureAlgorithmOID to auto-id package.
  • blake2b_256 to auto-utils package.
  • corresponding tests as well.

@abhi3700 abhi3700 self-assigned this Jun 10, 2024
@abhi3700 abhi3700 added enhancement New feature or request auto-utils Any common functions between consensus & auto-id auto-id Anything related to Auto-ID labels Jun 10, 2024
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with just a couple comments

packages/auto-id/package.json Outdated Show resolved Hide resolved
packages/auto-id/package.json Outdated Show resolved Hide resolved
Old ASN library is replaced by the new one because it has high no. of downloads/week although the last commit is 2 years old.
@abhi3700 abhi3700 closed this Jun 11, 2024
@abhi3700 abhi3700 deleted the fix-issue-15 branch June 11, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-id Anything related to Auto-ID auto-utils Any common functions between consensus & auto-id enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auto-kit's utils functions into auto-utils package.
2 participants