fix acme mount for LE

[DaMandal0rian]

PR Type

bug_fix

---

Description

• Fixed the volume mount path for acme.json in multiple shell scripts.
• Ensured consistent path usage across different node compose files.

---

Changes walkthrough 📝

Relevant files

Bug fix

create_domain_node_compose_file.sh Corrected acme.json volume mount path                                        templates/scripts/create_domain_node_compose_file.sh Fixed the path for the acme.json volume mount. +1/-1      create_rpc_node_compose_file.sh Corrected acme.json volume mount path                                        templates/scripts/create_rpc_node_compose_file.sh Fixed the path for the acme.json volume mount. +1/-1      create_domain_node_compose_file.sh Corrected acme.json volume mount path                                        testing-framework/ec2/base/scripts/create_domain_node_compose_file.sh Fixed the path for the acme.json volume mount. +1/-1      create_node_compose_file.sh Corrected acme.json volume mount path                                        testing-framework/ec2/base/scripts/create_node_compose_file.sh Fixed the path for the acme.json volume mount. +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Path Consistency The change from './letsencrypt/acme.json' to './acme.json' should be validated to ensure that the new path correctly points to the intended file location in all deployment environments. Path Consistency Similar to the domain node script, verify that the updated path './acme.json' is accessible and correctly configured in the deployment context. Path Consistency Ensure that the path change to './acme.json' does not affect the functionality or accessibility of the file in test environments. Path Consistency Confirm that the new path './acme.json' is correctly integrated and functions as expected within the node composition in test setups.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Security	Secure the acme.json file by setting read-only permissions in the Docker volume mapping Ensure that the acme.json file has the correct permissions set to secure sensitive data. templates/scripts/create_domain_node_compose_file.sh [74] -- ./acme.json:/acme.json +- ./acme.json:/acme.json:ro Suggestion importance[1-10]: 8 Why: Setting the acme.json file to read-only in the Docker volume mapping enhances security by preventing accidental or malicious modifications, which is crucial for sensitive data.	8
Maintainability	Update all dependencies to align with the new acme.json file location Confirm that all dependent services and scripts are updated to reflect the new location of acme.json. testing-framework/ec2/base/scripts/create_node_compose_file.sh [41] +- ./acme.json:/acme.json - Suggestion importance[1-10]: 3 Why: Updating dependencies is important for maintainability, but the suggestion lacks specifics on what needs to be updated, making it less impactful without further details.	3
Possible issue	Ensure the Docker container can access the acme.json file at its new path Verify that the new path for acme.json is correctly configured and accessible by the Docker container. templates/scripts/create_rpc_node_compose_file.sh [73] +- ./acme.json:/acme.json - Suggestion importance[1-10]: 2 Why: The suggestion is valid but only asks to verify the accessibility of the acme.json file without providing a concrete improvement or identifying a specific issue.	2
	Assess and resolve any environment-specific conflicts due to the acme.json path change Check for potential conflicts or issues caused by the change in the file path of acme.json across different environments. testing-framework/ec2/base/scripts/create_domain_node_compose_file.sh [42] +- ./acme.json:/acme.json - Suggestion importance[1-10]: 2 Why: The suggestion to check for conflicts is a preventive measure but lacks actionable details and does not address a specific problem in the PR.	2