Fix evm gas estimate bug #2833
Merged
Fix evm gas estimate bug #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dastansam
requested review from
vedhavyas,
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
vedhavyas
previously approved these changes
Jun 11, 2024
| @@ -40,3 +40,7 @@ sp-core = { git = "https://github.com/subspace/polkadot-sdk", rev = "6da3c45e1d5 | |||
| sp-inherents = { git = "https://github.com/subspace/polkadot-sdk", rev = "6da3c45e1d5b3c1f09b5e54152b8848149f9d5e6" } | |||
| sp-runtime = { git = "https://github.com/subspace/polkadot-sdk", rev = "6da3c45e1d5b3c1f09b5e54152b8848149f9d5e6" } | |||
| substrate-frame-rpc-system = { git = "https://github.com/subspace/polkadot-sdk", rev = "6da3c45e1d5b3c1f09b5e54152b8848149f9d5e6" } | |||
|
|
|||
| [features] | |||
| default = ["rpc-binary-search-estimate"] | |||
There was a problem hiding this comment.
I'm sure I have enabled this for evm specific crates.
|
It works fine with
|
dastansam
force-pushed
the
evm-domain-gas-estimate-fix
branch
from
7d1f1fe
to
fb893a9
Compare
yeah that was the idea. Without this PR it fails with out of gas even with skip simulation. You can try that as well, if you have time of course |
vedhavyas
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpc-binary-search-estimatedefault and switches it onpallet-ethereumprovided weight converter function to derive weight limit and proof size base costpartially fixes #2773
cc @abhi3700 could you please try it yourself as well, compile the node/domain with this fix and using
--skip-simulationCode contributor checklist: