-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: optimize cluster identification #3032
Open
tediou5
wants to merge
9
commits into
autonomys:main
Choose a base branch
from
tediou5:opt/optimize-cluster-identification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+657
−102
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f4f409b
chore: moving FarmIndex into cluster::farmer
tediou5 c1d4a22
chore: tiny refactoring for cluster farm
tediou5 2017568
feat: derive sub farm_ids from a farm_id
tediou5 1c70a89
opt: optimize farm identification
tediou5 3f285f4
feat: derive sub cache_ids from a cache_id
tediou5 8087b87
chore: tiny refactoring for cluster cache
tediou5 db67397
opt: optimize cache identification
tediou5 1fa5cdd
chore: add debug log when farm or cache updating last identification
tediou5 fdad7e5
fix typo
tediou5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
use crate::farm::FarmId; | ||
|
||
#[test] | ||
fn derive_sub_farm_ids_test() { | ||
let id = FarmId::new(); | ||
let sub_ids = id.derive_sub_ids(128); | ||
assert_eq!(sub_ids.len(), 128); | ||
|
||
match id { | ||
FarmId::Ulid(id) => { | ||
let id: u128 = id.into(); | ||
sub_ids.into_iter().zip(0..128u128).for_each(|(sub_id, i)| { | ||
let FarmId::Ulid(sub_id) = sub_id; | ||
let sub_id: u128 = sub_id.into(); | ||
assert_eq!(sub_id, id + i); | ||
}); | ||
} | ||
}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes no sense to me, can you explain what this is supposed to mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a child id derived from a farmer or cache avoids the need to transfer farm ids, which would make it redundant to randomize new ids for each farm when the farmer or cache is already randomly generating ids.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still makes no sense to me, sorry.
This is farm ID, just one of the many farms the farmer is managing. Other farms have different IDs. I don't understand what this derivation has to do with any of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove him if you don't think it's necessary, it doesn't affect the overall logic here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand why it was added in the first place and so far it doesn't really make sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does make it confusing, maybe I should change the type to FarmerId.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes no sense to me either way. You need to transfer the same information that was transferred before these changes anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way we need to know what farms are inside the farmer, recorded or derived, so you prefer to record the farms_id inside the farmer in the controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are already
farm_id
s of individual farms in the controller. What needs to be is to group them by farmer ID somehow and only transfer details once during initialization.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know what you mean. I'll try it later.