Fix the max domain block weight usage #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is the same as the upstream check_weight extension except the max_block weight limit check is removed since there is only a target max block weight but the actual total block weight is probabilistic Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
…c value Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
teor2345
reviewed
Nov 5, 2024
Co-authored-by: teor <[email protected]>
Co-authored-by: teor <[email protected]>
teor2345
approved these changes
Nov 7, 2024
NingLin-P
added
need to audit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3193
In main, the domain runtime uses a MAX value as the max block weight because even though we have a target max domain block weight the actual total domain block weight is probabilistic, which causes issues when calculating the weight usage and remaining weight in block, etc, see #3193 for more detail.
This PR fixes the issue by using a realistic value as the max block weight in the domain runtime instead of the MAX value. To workaround the probabilistic domain block weight, it introduces a customized
check_weightextension, which is the same as the upstream one except themax_blockweight limit check is removed (the alternative is to continue using the MAX value in thecheck_weightextension but a realistic value in other places but it is too hack and a lot of redundant code).Note this PR replaces the upstream
check_weightextension with the customized one in a few more places in the EVM domain runtime, and it also fixes a minor issue about accounting thebase_extrinsicweight in the bundle weight check.Code contributor checklist: