Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for object mapping yes/no change #3227

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

teor2345
Copy link
Contributor

The argument names were changed but the docs weren’t updated.

Code contributor checklist:

@teor2345 teor2345 added the documentation Improvements or additions to documentation label Nov 10, 2024
@teor2345 teor2345 self-assigned this Nov 10, 2024
@teor2345
Copy link
Contributor Author

Weird, none of the checks ran on this.

@shamil-gadelshin
Copy link
Member

Weird, none of the checks ran on this.

"Update base branch" will likely help.

@nazar-pc
Copy link
Member

This is the second time I see this, same happened to me last week

@nazar-pc nazar-pc merged commit abc5a1d into main Nov 11, 2024
@nazar-pc nazar-pc deleted the obj-map-yes-doc branch November 11, 2024 08:54
@nazar-pc
Copy link
Member

Ah, this is probably due to only markdown files being changed, I think we ignore such changes in CI, but probably shouldn't to make these PRs mergeable 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants