Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send transactions to synced peers #3230

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Nov 12, 2024

This includes autonomys/polkadot-sdk@94a1a81?w=1 (pushed this one commit into subspace-v8 branch) to deal with paritytech/polkadot-sdk#6434 until there is an upstream solution to this problem.

My node runs with this, but can't verify savings easily, especially now that history seeding is over.

Code contributor checklist:

Copy link
Member

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The polkadot-sdk fork commit looks straightforward.

NingLin-P
NingLin-P previously approved these changes Nov 12, 2024
@nazar-pc nazar-pc force-pushed the only-send-transactions-to-synced-peers branch from 150551e to 8432032 Compare November 12, 2024 11:11
@nazar-pc
Copy link
Member Author

I updated patch with if has_synced_changed to avoid excessive notifications:
autonomys/polkadot-sdk@94a1a81?w=1#diff-9ab3391aa82ee2b2868ece610100f84502edcf40638dba9ed6953b6e572dfba5R441-R450

@nazar-pc nazar-pc merged commit 96cb482 into main Nov 12, 2024
10 checks passed
@nazar-pc nazar-pc deleted the only-send-transactions-to-synced-peers branch November 12, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants