Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Geneious Prime Recipe to support latest version (2020) #128

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

TK5-Tim
Copy link

@TK5-Tim TK5-Tim commented Sep 30, 2020

Continuation of #96 to finish the work my predecessor did.

The change is needed, because Geneious has a different link in there Versions.txt than the actual URL. With just one character being different. I tried to convince their support to change what seems to be a typo but they are not willing to do that.

Output of a successful run of autopkg run -vv com.github.n8felton.geneious.download:

Processing com.github.n8felton.geneious.download...
WARNING: com.github.n8felton.geneious.download is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
URLTextSearcher
{'Input': {'re_pattern': '2020 release release.*(Geneious.*mac.*dmg)',
           'url': 'https://desktop-links.geneious.com/assets/installers/geneious/GeneiousVersions.txt'}}
URLTextSearcher: No value supplied for result_output_var_name, setting default value of: match
URLTextSearcher: Found matching text (match): Geneious_Prime-mac64_2020_2_4_with_jre.dmg
{'Output': {'match': 'Geneious_Prime-mac64_2020_2_4_with_jre.dmg'}}
com.github.n8felton.shared/RegexReplace
{'Input': {'replace_pattern': '-',
           'replace_string': '_',
           'result_output_var_name': 'match',
           'source_string': 'Geneious_Prime-mac64_2020_2_4_with_jre.dmg'}}
RegexReplace: No value supplied for replace_count, setting default value of: 0
{'Output': {'match': 'Geneious_Prime_mac64_2020_2_4_with_jre.dmg'}}
URLDownloader
{'Input': {'url': 'https://assets.geneious.com/installers/geneious/release/Geneious_Prime_mac64_2020_2_4_with_jre.dmg'}}
URLDownloader: No value supplied for prefetch_filename, setting default value of: False
URLDownloader: No value supplied for CHECK_FILESIZE_ONLY, setting default value of: False
URLDownloader: Storing new Last-Modified header: Thu, 17 Sep 2020 01:17:14 GMT
URLDownloader: Storing new ETag header: "96f20d31de856566d252887b69c958d7-14"
URLDownloader: Downloaded /Users/keltim01/Library/AutoPkg/Cache/com.github.n8felton.geneious.download/downloads/Geneious_Prime_mac64_2020_2_4_with_jre.dmg
{'Output': {'download_changed': True,
            'etag': '"96f20d31de856566d252887b69c958d7-14"',
            'last_modified': 'Thu, 17 Sep 2020 01:17:14 GMT',
            'pathname': '/Users/keltim01/Library/AutoPkg/Cache/com.github.n8felton.geneious.download/downloads/Geneious_Prime_mac64_2020_2_4_with_jre.dmg',
            'url_downloader_summary_result': {'data': {'download_path': '/Users/keltim01/Library/AutoPkg/Cache/com.github.n8felton.geneious.download/downloads/Geneious_Prime_mac64_2020_2_4_with_jre.dmg'},
                                              'summary_text': 'The following '
                                                              'new items were '
                                                              'downloaded:'}}}
EndOfCheckPhase
{'Input': {}}
{'Output': {}}
CodeSignatureVerifier
{'Input': {'input_path': '/Users/keltim01/Library/AutoPkg/Cache/com.github.n8felton.geneious.download/downloads/Geneious_Prime_mac64_2020_2_4_with_jre.dmg/Geneious*.app',
           'requirement': 'identifier "com.biomatters.Geneious" and anchor '
                          'apple generic and certificate '
                          '1[field.1.2.840.113635.100.6.2.6] /* exists */ and '
                          'certificate leaf[field.1.2.840.113635.100.6.1.13] '
                          '/* exists */ and certificate leaf[subject.OU] = '
                          '"3BTDDQD3L6"'}}
CodeSignatureVerifier: Mounted disk image /Users/keltim01/Library/AutoPkg/Cache/com.github.n8felton.geneious.download/downloads/Geneious_Prime_mac64_2020_2_4_with_jre.dmg
CodeSignatureVerifier: Using path '/private/tmp/dmg.qVVZ79/Geneious Prime.app' matched from globbed '/private/tmp/dmg.qVVZ79/Geneious*.app'.
CodeSignatureVerifier: Verifying code signature...
CodeSignatureVerifier: Deep verification enabled...
CodeSignatureVerifier: Strict verification not defined. Using codesign defaults...
CodeSignatureVerifier: /private/tmp/dmg.qVVZ79/Geneious Prime.app: valid on disk
CodeSignatureVerifier: /private/tmp/dmg.qVVZ79/Geneious Prime.app: satisfies its Designated Requirement
CodeSignatureVerifier: /private/tmp/dmg.qVVZ79/Geneious Prime.app: explicit requirement satisfied
CodeSignatureVerifier: Signature is valid
{'Output': {}}
Receipt written to /Users/keltim01/Library/AutoPkg/Cache/com.github.n8felton.geneious.download/receipts/com.github.n8felton.geneious-receipt-20200930-154005.plist

The following new items were downloaded:
    Download Path                                                                                                                     
    -------------                                                                                                                     
    /Users/keltim01/Library/AutoPkg/Cache/com.github.n8felton.geneious.download/downloads/Geneious_Prime_mac64_2020_2_4_with_jre.dmg  

Thank you very much @tcinbis for the useful processor!

Tom Cinbis and others added 8 commits March 21, 2019 10:52
Because the download url for Geneious Prime slightly diverges from the
information found in the versions.txt an additional RegexReplace Processor is required.
With the modified download recipe both version (20 and 2019) can be downloaded by
modifiying the input variables.
@TK5-Tim
Copy link
Author

TK5-Tim commented Oct 7, 2020

@n8felton @CWhits It would be great if you could take a look at this. I tried to finish the work of my predecessor in #96 so that the Recipe works with Geneious Prime 2020.

@TK5-Tim
Copy link
Author

TK5-Tim commented Dec 9, 2020

@n8felton @CWhits I would very appreciate if you could take a look at this PR if you find the time.
Thank you very much and happy holidays :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant