chore(ios): clean up sharing feature flags

autoreleasefool · Sep 9, 2024 · 29ec98a · 29ec98a
1 parent 47c5949
commit 29ec98a
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 29 deletions.
diff --git a/ios/Approach/Sources/FeatureFlagsLibrary/FeatureFlags.swift b/ios/Approach/Sources/FeatureFlagsLibrary/FeatureFlags.swift
@@ -6,13 +6,10 @@ extension FeatureFlag {
 	public static let developerOptions = Self(name: "developerOptions", introduced: "2022-11-10", stage: .development, isOverridable: false)
 	public static let teams = Self(name: "teams", introduced: "2023-01-03", stage: .development)
 	public static let opponentDetails = Self(name: "opponentDetails", introduced: "2023-08-18", stage: .development)
-	public static let sharingGame = Self(name: "sharingGame", introduced: "2023-08-29", stage: .release)
-	public static let sharingSeries = Self(name: "sharingSeries", introduced: "2023-08-29", stage: .release)
 	public static let alleyAndGearAverages = Self(name: "alleyAndGearAverages", introduced: "2023-09-12", stage: .development)
 	public static let proSubscription = Self(name: "proSubscription", introduced: "2023-08-08", stage: .development)
 	public static let purchases = Self(name: "purchase", introduced: "2023-09-15", stage: .disabled)
 	public static let dataImport = Self(name: "dataImport", introduced: "2023-09-17", stage: .release)
-	public static let sharingStatistic = Self(name: "sharingStatistic", introduced: "2024-04-27", stage: .release)
 	public static let photoAvatars = Self(name: "photoAvatars", introduced: "2024-07-05", stage: .development)
 	public static let bowlerDetails = Self(name: "bowlerDetails", introduced: "2024-07-05", stage: .development)
 	public static let highestScorePossible = Self(name: "highestScorePossible", introduced: "2024-08-14", stage: .development)
@@ -27,9 +24,6 @@ extension FeatureFlag {
 		.photoAvatars,
 		.proSubscription,
 		.purchases,
-		.sharingGame,
-		.sharingSeries,
-		.sharingStatistic,
 		.teams,
 	]
 

diff --git a/ios/Approach/Sources/GamesEditorFeature/Manage/GamesHeader.swift b/ios/Approach/Sources/GamesEditorFeature/Manage/GamesHeader.swift
@@ -2,7 +2,6 @@ import AnalyticsServiceInterface
 import AssetsLibrary
 import ComposableArchitecture
 import FeatureActionLibrary
-import FeatureFlagsLibrary
 import ModelsLibrary
 import PreferenceServiceInterface
 import StringsLibrary
@@ -14,15 +13,11 @@ public struct GamesHeader: Reducer, Sendable {
 	@ObservableState
 	public struct State: Equatable {
 		public var currentGameIndex: Int = 0
-		public let isSharingGameEnabled: Bool
 		public var shimmerColor: Color?
 
 		public var isFlashEditorChangesEnabled: Bool
 
 		init() {
-			@Dependency(\.featureFlags) var featureFlags
-			self.isSharingGameEnabled = featureFlags.isFlagEnabled(.sharingGame)
-
 			@Dependency(\.preferences) var preferences
 			self.isFlashEditorChangesEnabled = preferences.bool(forKey: .gameShouldNotifyEditorChanges) ?? true
 		}
@@ -145,9 +140,7 @@ public struct GamesHeaderView: View {
 
 				Spacer()
 
-				if store.isSharingGameEnabled {
-					headerButton(systemSymbol: .squareAndArrowUp) { send(.didTapShareButton) }
-				}
+				headerButton(systemSymbol: .squareAndArrowUp) { send(.didTapShareButton) }
 
 				headerButton(systemSymbol: .gear) { send(.didTapSettingsButton) }
 			}

diff --git a/ios/Approach/Sources/GamesListFeature/GamesList.swift b/ios/Approach/Sources/GamesListFeature/GamesList.swift
@@ -4,7 +4,6 @@ import ComposableArchitecture
 import EquatablePackageLibrary
 import ErrorsFeature
 import FeatureActionLibrary
-import FeatureFlagsLibrary
 import Foundation
 import GamesEditorFeature
 import GamesRepositoryInterface
@@ -52,9 +51,6 @@ public struct GamesList: Reducer, Sendable {
 				)
 			)
 
-			@Dependency(\.featureFlags) var featureFlags
-			self.isSeriesSharingEnabled = featureFlags.isFlagEnabled(.sharingSeries)
-
 			@Dependency(TipsService.self) var tips
 			self.isShowingArchiveTip = tips.shouldShow(tipFor: .gameArchiveTip)
 		}

diff --git a/ios/Approach/Sources/StatisticsDetailsFeature/StatisticsDetails.swift b/ios/Approach/Sources/StatisticsDetailsFeature/StatisticsDetails.swift
@@ -2,8 +2,6 @@ import AnalyticsServiceInterface
 import ComposableArchitecture
 import ErrorsFeature
 import FeatureActionLibrary
-import FeatureFlagsLibrary
-import FeatureFlagsPackageServiceInterface
 import NotificationsServiceInterface
 import PreferenceServiceInterface
 import RecentlyUsedServiceInterface
@@ -40,8 +38,6 @@ public struct StatisticsDetails: Reducer, Sendable {
 
 		public var charts: StatisticsDetailsCharts.State
 
-		public let isSharingStatisticsEnabled: Bool
-
 		@Presents public var destination: Destination.State?
 
 		var filterViewSize: StatisticsFilterView.Size {
@@ -65,9 +61,6 @@ public struct StatisticsDetails: Reducer, Sendable {
 
 			@Dependency(\.date) var date
 			self.willAdjustLaneLayoutAt = date()
-
-			@Dependency(\.featureFlags) var featureFlags
-			self.isSharingStatisticsEnabled = featureFlags.isFlagEnabled(.sharingStatistic)
 		}
 
 		mutating func syncChartsSharedState() {

diff --git a/ios/Approach/Sources/StatisticsDetailsFeature/StatisticsDetailsView.swift b/ios/Approach/Sources/StatisticsDetailsFeature/StatisticsDetailsView.swift
@@ -50,10 +50,8 @@ public struct StatisticsDetailsView: View {
 		.navigationTitle(store.sources?.bowler.name ?? "")
 		.navigationBarTitleDisplayMode(.inline)
 		.toolbar {
-			if store.isSharingStatisticsEnabled {
-				ToolbarItem(placement: .navigationBarTrailing) {
-					ShareButton { send(.didTapShareButton) }
-				}
+			ToolbarItem(placement: .navigationBarTrailing) {
+				ShareButton { send(.didTapShareButton) }
 			}
 
 			ToolbarItem(placement: .navigationBarTrailing) {