-
Notifications
You must be signed in to change notification settings - Fork 168
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add network case of update device of interface type
- VIRT-298342 - [update-device] live update interface with different interface type - bridge/direct type Signed-off-by: Haijiao Zhao <[email protected]>
- Loading branch information
Showing
2 changed files
with
111 additions
and
0 deletions.
There are no files selected for viewing
14 changes: 14 additions & 0 deletions
14
libvirt/tests/cfg/virtual_network/update_device/update_iface_type_live.cfg
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
- virtual_network.update_device.iface_type.live: | ||
type = update_iface_type_live | ||
host_iface = | ||
start_vm = no | ||
timeout = 240 | ||
variants: | ||
- bridge_type: | ||
iface_type = bridge | ||
create_linux_br = yes | ||
net_attrs = {'name': net_name, 'bridge': {'name': linux_br}, 'forward': {'mode': 'bridge'}} | ||
- direct_type: | ||
iface_type = direct | ||
net_attrs = {'name': net_name, 'forward': {'mode': 'bridge'}, 'forward_interface': [{'dev': host_iface}]} | ||
iface_attrs = {'model': 'virtio', 'type_name': 'network', 'source': {'network': net_name}, 'mac_address': mac} |
97 changes: 97 additions & 0 deletions
97
libvirt/tests/src/virtual_network/update_device/update_iface_type_live.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
import logging | ||
import re | ||
|
||
from virttest import utils_misc | ||
from virttest import utils_net | ||
from virttest import virsh | ||
from virttest.libvirt_xml import vm_xml | ||
from virttest.utils_libvirt import libvirt_network | ||
from virttest.utils_libvirt import libvirt_vmxml | ||
|
||
VIRSH_ARGS = {'ignore_status': False, 'debug': True} | ||
|
||
LOG = logging.getLogger('avocado.' + __name__) | ||
|
||
|
||
def run(test, params, env): | ||
""" | ||
Test update-device for bridge or direct type interface | ||
""" | ||
vm_name = params.get('main_vm') | ||
vm = env.get_vm(vm_name) | ||
rand_id = utils_misc.generate_random_string(3) | ||
create_linux_br = 'yes' == params.get('create_linux_br', 'no') | ||
linux_br = 'linux_br_' + rand_id | ||
net_name = 'net_' + rand_id | ||
mac = utils_net.generate_mac_address_simple() | ||
iface_attrs = eval(params.get('iface_attrs', '{}')) | ||
iface_type = params.get('iface_type') | ||
host_iface = params.get('host_iface') | ||
host_iface = host_iface if host_iface else utils_net.get_net_if( | ||
state='UP')[0] | ||
net_attrs = eval(params.get('net_attrs', '{}')) | ||
|
||
vmxml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name) | ||
bkxml = vmxml.copy() | ||
|
||
try: | ||
vmxml.del_device('interface', by_tag=True) | ||
vmxml.sync() | ||
LOG.debug(f'VMXML of {vm_name}:\n{virsh.dumpxml(vm_name).stdout_text}') | ||
|
||
if create_linux_br: | ||
LOG.debug(f'Create linux bridge: {linux_br}') | ||
utils_net.create_linux_bridge_tmux(linux_br, host_iface) | ||
libvirt_network.create_or_del_network(net_attrs) | ||
LOG.debug(f'Network xml:\n' | ||
f'{virsh.net_dumpxml(net_attrs["name"]).stdout_text}') | ||
|
||
vm.start() | ||
session = vm.wait_for_serial_login() | ||
|
||
iface = libvirt_vmxml.create_vm_device_by_type( | ||
'interface', iface_attrs) | ||
LOG.debug(f'Interface to attach:\n{iface}') | ||
|
||
virsh.attach_device(vm_name, iface.xml, **VIRSH_ARGS) | ||
|
||
vmxml = vm_xml.VMXML.new_from_dumpxml(vm_name) | ||
iface_at = vmxml.get_devices('interface')[0] | ||
LOG.debug(f'Interface xml after attached to vm:\n{iface_at}') | ||
LOG.debug(f'Interface type after attached to vm:\n' | ||
f'{iface_at.type_name}') | ||
if iface_at.type_name != iface_type: | ||
test.fail(f'Interface type should change to {iface_type}') | ||
|
||
LOG.debug('Update interface link state') | ||
link_state = 'down' | ||
iface.setup_attrs(**{'link_state': link_state}) | ||
LOG.debug(iface) | ||
|
||
virsh.update_device(vm_name, iface.xml, **VIRSH_ARGS) | ||
vmxml = vm_xml.VMXML.new_from_dumpxml(vm_name) | ||
iface_update = vmxml.get_devices('interface')[0] | ||
LOG.debug(f'Link state of interface after update: ' | ||
f'{iface_update.link_state}') | ||
if iface_update.link_state != link_state: | ||
test.fail(f'Link state of interface after update should be ' | ||
f'{link_state}') | ||
|
||
vm_iface = utils_net.get_linux_ifname(session, mac) | ||
LOG.debug(f'Interface inside vm: {vm_iface}') | ||
|
||
LOG.debug('Check link state inside vm via ethtool command') | ||
eth_output = session.cmd_output(f'ethtool {vm_iface}') | ||
LOG.debug(f'ethtool output:\s{eth_output}') | ||
if re.search('Link\sdetected:\sno', eth_output) is None: | ||
test.fail('ethtool output not correct, should contain' | ||
'"Link detected: no"') | ||
session.close() | ||
|
||
finally: | ||
bkxml.sync() | ||
if net_attrs: | ||
libvirt_network.create_or_del_network(net_attrs, is_del=True) | ||
if create_linux_br: | ||
LOG.debug(f'Delete linux bridge: {linux_br}') | ||
utils_net.delete_linux_bridge_tmux(linux_br, host_iface) |