Skip to content

Commit

Permalink
sriov: fix ipxe rom file issue
Browse files Browse the repository at this point in the history
Relying on ipxe build in tests when cannot obtain VF pxe rom file is an unstable testing method. Because this case is mainly to test the xml but not the pxe function. So we decided to use the fixed virtio rom file to test.

Signed-off-by: Meina Li <[email protected]>
  • Loading branch information
meinaLi committed Dec 20, 2024
1 parent b79fc7b commit 9791a4a
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions provider/sriov/sriov_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,12 +258,11 @@ def get_rom_file(self):
rom_vendor_device = lspci_stdout[1:-1].replace(':', '') + '.rom'
rom_file = os.path.join('/usr/share/ipxe', rom_vendor_device)
if not os.path.exists(rom_file):
build_cmd = "git clone https://github.com/ipxe/ipxe.git;\
pushd ipxe/src; make bin/{0}; cp bin/{0} {1}; popd; \
rm -rf ipxe".format(rom_vendor_device, rom_file)
process.run(build_cmd, shell=True, verbose=True)
# Directly use virtio rom file because it mainly test xml but not pxe function.
rom_file = "/usr/share/ipxe/1af41000.rom"
if not os.path.exists(rom_file):
self.test.error("This test needs rom file: %s." % rom_file)
self.test.error("This test needs rom file but the virtio rom file also doesn't exist: %s."
% rom_file)
return rom_file

def create_iface_dev(self, dev_type, iface_dict):
Expand Down

0 comments on commit 9791a4a

Please sign in to comment.