Skip to content

Commit

Permalink
virsh_detach_device_alias: remove test.skip
Browse files Browse the repository at this point in the history
test.skip is not used any more.

Signed-off-by: Dan Zheng <[email protected]>
  • Loading branch information
dzhengfy committed Nov 29, 2024
1 parent 0791fc0 commit a4db6dd
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def start_usbredirserver():
if input_type == "passthrough":
event = process.run("ls /dev/input/event*", shell=True, ignore_status=True).stdout
if len(event) == 0:
test.skip("Not found any input devices")
test.cancel("Not found any input devices")
input_dict.update({"source_evdev": event.decode('utf-8').split()[0]})

input_obj = Input(type_name=input_type)
Expand Down
2 changes: 1 addition & 1 deletion libvirt/tests/src/virtual_disks/virtual_disks_gluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def test_pmsuspend(vm_name):
virsh.undefine(vm_name, '--nvram', ignore_status=False)
if virsh.create(vmxml_for_test.xml, **virsh_dargs).exit_status:
vmxml_backup.define()
test.skip("can't create the domain")
test.cancel("can't create the domain")

# Run the tests.
if pm_enabled:
Expand Down
2 changes: 1 addition & 1 deletion libvirt/tests/src/virtual_network/iface_coalesce.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def run(test, params, env):
"""

if not libvirt_version.version_compare(3, 3, 0):
test.skip("Coalesce setting is only supported by libvirt3.3.0 and above")
test.cancel("Coalesce setting is only supported by libvirt3.3.0 and above")

vm_name = params.get("main_vm")
vm = env.get_vm(vm_name)
Expand Down
4 changes: 2 additions & 2 deletions libvirt/tests/src/vm_boot_with_kernel_param.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def run(test, params, env):
cpu_model = cpu.get_cpu_info()['Model name'].upper()
if cpu_check not in cpu_model:
logging.info("This test will work for %s", cpu_check)
test.skip("Test is not applicable for %s" % cpu_model)
test.cancel("Test is not applicable for %s" % cpu_model)
# back up vmxml
for vm_name in vms:
vm_dict[vm_name] = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name)
Expand All @@ -78,7 +78,7 @@ def run(test, params, env):
test.error("couldn't get cpu information from guest "
"%s" % vm.name)
if cpu_check not in output.upper() and "radix" in boot_log:
test.skip("radix MMU not supported in %s" % output)
test.cancel("radix MMU not supported in %s" % output)
status, output = session.cmd_status_output("dmesg")
if status:
logging.error(output)
Expand Down

0 comments on commit a4db6dd

Please sign in to comment.