Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory xml not match #4994

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix memory xml not match #4994

merged 1 commit into from
Jul 4, 2023

Conversation

nanli1
Copy link
Contributor

@nanli1 nanli1 commented Jun 28, 2023 •
edited
Loading

First case:
Before fixed

 avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 memory.allocation.invalid_value.numa.zero --vt-connect-uri qemu:///system

 (1/1) type_specific.io-github-autotest-libvirt.memory.allocation.invalid_value.numa.zero: FAIL: XML did not match text '0' for the xpath './/cell[@id='0']' (8.01 s)

After fixed, lcong has confirmed that the test should cancel if libvirt version <9.0 for zero &numa scenario

avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 memory.allocation.invalid_value.numa.zero --vt-connect-uri qemu:///system
 (1/1) type_specific.io-github-autotest-libvirt.memory.allocation.invalid_value.numa.zero: CANCEL: This libvirt version doesn't support this function. (7.36 s)

@nanli1 nanli1 marked this pull request as draft June 28, 2023 03:23
@nanli1
Copy link
Contributor Author

nanli1 commented Jun 28, 2023 •
edited
Loading

Second case :

Before fixed

 avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 memory.allocation.lifecycle.positive_test.with_numa --vt-connect-uri qemu:///system
 (1/1) type_specific.io-github-autotest-libvirt.memory.allocation.lifecycle.positive_test.with_numa: ERROR: Failed to undefine avocado-vt-vm1. (41.39 s)

After fixed

avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 memory.allocation.invalid_value.numa.zero --vt-connect-uri qemu:///system

 (1/1) type_specific.io-github-autotest-libvirt.memory.allocation.invalid_value.numa.zero: PASS (5.67 s)

@nanli1 nanli1 force-pushed the fix_memory_xpath_not_match branch from e0a1393 to c34f2c3 Compare June 28, 2023 04:11
@hs0210
Copy link
Contributor

hs0210 commented Jul 3, 2023

It seems that the fix works fine with aarch64

 (1/1) type_specific.io-github-autotest-libvirt.memory.allocation.invalid_value.numa.zero: PASS (7.16 s)
 (1/1) type_specific.io-github-autotest-libvirt.memory.allocation.lifecycle.positive_test.with_numa: PASS (90.06 s)

@nanli1 nanli1 force-pushed the fix_memory_xpath_not_match branch from c34f2c3 to a4f30a5 Compare July 3, 2023 10:02
@nanli1
Copy link
Contributor Author

nanli1 commented Jul 3, 2023

It seems that the fix works fine with aarch64

 (1/1) type_specific.io-github-autotest-libvirt.memory.allocation.invalid_value.numa.zero: PASS (7.16 s)
 (1/1) type_specific.io-github-autotest-libvirt.memory.allocation.lifecycle.positive_test.with_numa: PASS (90.06 s)

It's weird
feature owner lcong confirmed that it's libvirt version issue.

@nanli1 nanli1 marked this pull request as ready for review July 3, 2023 10:11
@hs0210
Copy link
Contributor

hs0210 commented Jul 4, 2023

I'm not clear about this, the following is the debug log and test env.

Debug log:

04:49:14 INFO | TEST_STEP3: Check start vm get correct result
04:49:15 DEBUG| Command result:

error: Failed to start domain 'avocado-vt-vm1'
error: internal error: qemu unexpectedly closed the monitor: 2023-07-03T08:49:15.322522Z qemu-kvm: property 'size' of memory-backend-ram doesn't take value '0'

04:49:15 INFO | Get expect error msg:error: Failed to start domain 'avocado-vt-vm1'
error: internal error: qemu unexpectedly closed the monitor: 2023-07-03T08:49:15.322522Z qemu-kvm: property 'size' of memory-backend-ram doesn't take value '0'

Test env:

libvirt-8.0.0-21
qemu-kvm-6.2.0-35

@nanli1
Copy link
Contributor Author

nanli1 commented Jul 4, 2023

I'm not clear about this, the following is the debug log and test env.

Debug log:

04:49:14 INFO | TEST_STEP3: Check start vm get correct result
04:49:15 DEBUG| Command result:

error: Failed to start domain 'avocado-vt-vm1'
error: internal error: qemu unexpectedly closed the monitor: 2023-07-03T08:49:15.322522Z qemu-kvm: property 'size' of memory-backend-ram doesn't take value '0'

04:49:15 INFO | Get expect error msg:error: Failed to start domain 'avocado-vt-vm1'
error: internal error: qemu unexpectedly closed the monitor: 2023-07-03T08:49:15.322522Z qemu-kvm: property 'size' of memory-backend-ram doesn't take value '0'

Test env:

libvirt-8.0.0-21
qemu-kvm-6.2.0-35

It's OK, And I skip the case if libvirt version < 9.0.0 as feature owner added in polarion case,

cliping
cliping approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@cliping cliping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chunfuwen
chunfuwen approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chunfuwen chunfuwen merged commit a7b3ad4 into autotest:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunfuwen chunfuwen chunfuwen approved these changes

@cliping cliping cliping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nanli1 @hs0210 @cliping @chunfuwen