-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guest_os_booting: fix the unsupported version issues #5001
Conversation
meinaLi
commented
Jun 29, 2023
•
edited
Loading
edited
|
It's '8.6' in your change, could you plz clarify what version should it be? |
Here I fixed two version issues. One is the --reset-nvram which is supported from libvirt-8.1.0. Another is the stateless element which is supported from libvirt-8.6.0. In this PR I added version support for the stateless but not the --reset-nvram(the description is explaining why we don't plan use --reset-nvram in this case again). |
Can you please update commit message so others can understand the issue correctly? BTW, I found that you just add the description in pr page, can you add them into commit too? |
Fix two version issues in this PR: 1) --reset-nvram option is not supported in RHEL8 but we need to test this auto case. So don't use it in the test steps. 2) The stateless is supported from libvirt-8.6.0. So test it from this version. Signed-off-by: Meina Li <[email protected]>
@Yingshun Please help to review again. |