Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numa_memory_spread: Make sure enough memory for guest #5005

Merged
merged 1 commit into from
Jul 5, 2023
Merged

numa_memory_spread: Make sure enough memory for guest #5005

merged 1 commit into from
Jul 5, 2023

Conversation

hs0210
Copy link
Contributor

@hs0210 hs0210 commented Jul 3, 2023

  1. Decrease memory size from the neighbour
  2. Drop caches first to make sure host has enough memory

Before:

ERROR| ERROR 1-type_specific.io-github-autotest-libvirt.numa_memory_spread.positive_test.default -> CmdError: Command '/usr/bin/virsh start avocado-vt-vm1 ' failed.
stdout: b'\n'
stderr: b"error: Failed to start domain 'avocado-vt-vm1'\nerror: internal error: qemu unexpectedly closed the monitor: 2023-07-03T08:21:57.926073Z qemu-kvm: cannot set up guest memory 'mach-virt.ram': Cannot allocate memory\n"

After:

INFO | PASS 1-type_specific.io-github-autotest-libvirt.numa_memory_spread.positive_test.default

@hs0210
numa_memory_spread: Make sure enough memory for guest
4a5998e 
1. Decrease memory size from the neighbour
2. Drop caches first to make sure host has enough memory

Signed-off-by: Hu Shuai <[email protected]>
dzhengfy
dzhengfy approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhengfy dzhengfy merged commit 7ba0e48 into autotest:master Jul 5, 2023
@hs0210 hs0210 deleted the numa_memory_spread branch September 14, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhengfy dzhengfy dzhengfy approved these changes

Assignees
No one assigned
Labels
minorfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hs0210 @dzhengfy