Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_memory_nodeset_placement: add case auto mem nodeset and placement #5039

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

@dzhengfy
Copy link
Contributor Author

dzhengfy commented Jul 19, 2023

libvirt 9.2.0

(01/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_strict.vcpu_auto: PASS (38.72 s) (02/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_strict.vcpu_static: PASS (41.63 s) (03/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_interleave.vcpu_auto: PASS (39.46 s) (04/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_interleave.vcpu_static: PASS (41.77 s) (05/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_preferred.vcpu_auto: PASS (39.09 s) (06/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_preferred.vcpu_static: PASS (41.62 s) (07/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_restrictive.vcpu_auto: PASS (40.09 s) (08/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_restrictive.vcpu_static: PASS (41.99 s) (09/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_none.vcpu_auto: PASS (38.60 s) (10/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_none.vcpu_static: PASS (41.63 s) (11/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_strict.vcpu_auto: PASS (39.59 s) (12/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_strict.vcpu_static: PASS (6.06 s) (13/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_interleave.vcpu_auto: PASS (39.52 s) (14/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_interleave.vcpu_static: PASS (6.00 s) (15/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_preferred.vcpu_auto: PASS (39.42 s) (16/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_preferred.vcpu_static: PASS (6.00 s) (17/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_restrictive.vcpu_auto: PASS (39.81 s) (18/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_restrictive.vcpu_static: PASS (5.81 s) (19/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_strict.vcpu_auto: PASS (39.72 s) (20/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_strict.vcpu_static: PASS (44.02 s) (21/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_interleave.vcpu_auto: PASS (38.74 s) (22/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_interleave.vcpu_static: PASS (42.14 s) (23/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_preferred.vcpu_auto: PASS (41.02 s) (24/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_preferred.vcpu_static: PASS (41.85 s) (25/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_restrictive.vcpu_auto: PASS (39.78 s) (26/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_restrictive.vcpu_static: PASS (42.23 s) (27/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_none.vcpu_auto: PASS (38.80 s) (28/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_none.vcpu_static: PASS (41.82 s) (29/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_strict.vcpu_auto: PASS (38.99 s) (30/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_strict.vcpu_static: PASS (6.00 s) (31/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_interleave.vcpu_auto: PASS (39.69 s) (32/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_interleave.vcpu_static: PASS (6.01 s) (33/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_preferred.vcpu_auto: PASS (39.73 s) (34/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_preferred.vcpu_static: PASS (5.74 s) (35/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_restrictive.vcpu_auto: PASS (39.72 s) (36/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_restrictive.vcpu_static: PASS (6.00 s) RESULTS : PASS 36 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0 JOB HTML : /var/lib/avocado/job-results/job-2023-07-19T02.26-b33ecfb/results.html JOB TIME : 1180.94 s

@dzhengfy dzhengfy force-pushed the case_auto_mem_nodeset_placement branch from a414587 to b394227 Compare July 19, 2023 08:48
@dzhengfy
Copy link
Contributor Author

dzhengfy commented Jul 19, 2023

libvirt 8.0.0
The failures (FAIL: Expect cpuset.mems=, but found 0-1) are due to bug on this libvirt version.

 (01/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_strict.vcpu_auto: WARN: Test passed but there were warnings during execution. Check the log for details. (33.74 s)
 (02/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_strict.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (30.11 s)
 (03/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_interleave.vcpu_auto: **FAIL: Expect cpuset.mems=, but found 0-1** (36.46 s)
 (04/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_interleave.vcpu_static: **FAIL: Expect cpuset.mems=, but found 0-1** (35.13 s)
 (05/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_preferred.vcpu_auto: **FAIL: Expect cpuset.mems=, but found 0-1** (36.17 s)
 (06/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_preferred.vcpu_static: **FAIL: Expect cpuset.mems=, but found 0-1** (34.13 s)
 (07/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_restrictive.vcpu_auto: **FAIL: Expect nodeset to be [0], but found [0, 1]** (35.97 s)
 (08/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_defined.mem_mode_restrictive.vcpu_static: **FAIL: Expect nodeset to be [0], but found [0, 1]** (34.74 s)
 (09/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_none.vcpu_auto: WARN: Test passed but there were warnings during execution. Check the log for details. (32.19 s)
 (10/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_none.vcpu_static: **FAIL: Expect cpuset.mems=, but found 0-1** (34.49 s)
 (11/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_strict.vcpu_auto: WARN: Test passed but there were warnings during execution. Check the log for details. (32.22 s)
 (12/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_strict.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (5.91 s)
 (13/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_interleave.vcpu_auto: **FAIL: Expect cpuset.mems=, but found 0-1** (37.59 s)
 (14/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_interleave.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (5.64 s)
 (15/36)type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_preferred.vcpu_auto: CANCEL: command: '/usr/bin/virsh start avocado-vt-vm1 '\nexit_status: 1\nduration: 2.3091739930096082\ninterrupted: False\npid: 72372\nencoding: 'UTF-8'\nstdout: '\n'\nstderr: "error: Failed to start domain 'avocado-vt-vm1'\nerror: internal error: Process exited prior t... (8.36 s)
 (16/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_preferred.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (5.69 s)
 (17/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_restrictive.vcpu_auto: WARN: Test passed but there were warnings during execution. Check the log for details. (32.08 s)
 (18/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.without_iothread.nodeset_undefined.mem_mode_restrictive.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (6.14 s)
 (19/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_strict.vcpu_auto: WARN: Test passed but there were warnings during execution. Check the log for details. (32.51 s)
 (20/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_strict.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (31.99 s)
 (21/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_interleave.vcpu_auto: **FAIL: Expect cpuset.mems=, but found 0-1** (37.64 s)
 (22/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_interleave.vcpu_static: **FAIL: Expect cpuset.mems=, but found 0-1** (34.31 s)
 (23/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_preferred.vcpu_auto: **FAIL: Expect cpuset.mems=, but found 0-1** (37.25 s)
 (24/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_preferred.vcpu_static: **FAIL: Expect cpuset.mems=, but found 0-1** (35.07 s)
 (25/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_restrictive.vcpu_auto: F**AIL: Expect nodeset to be [0], but found [0, 1]** (35.97 s)
 (26/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_defined.mem_mode_restrictive.vcpu_static: **FAIL: Expect nodeset to be [0], but found [0, 1]** (36.03 s)
 (27/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_none.vcpu_auto: WARN: Test passed but there were warnings during execution. Check the log for details. (33.35 s)
 (28/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_none.vcpu_static: FAIL: Expect cpuset.mems=, but found 0-1 (35.32 s)
 (29/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_strict.vcpu_auto: WARN: Test passed but there were warnings during execution. Check the log for details. (32.34 s)
 (30/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_strict.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (5.91 s)
 (31/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_interleave.vcpu_auto: **FAIL: Expect cpuset.mems=, but found 0-1** (36.35 s)
 (32/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_interleave.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (5.93 s)
 (33/36)CANCEL: command: '/bin/virsh start avocado-vt-vm1 '\nexit_status: 1\nduration: 2.3162900670140516\ninterrupted: False\npid: 73557\nencoding: 'UTF-8'\nstdout: '\n'\nstderr: "error: Failed to start domain 'avocado-vt-vm1'\nerror: internal error: Process exited prior to ex... (8.46 s)
 (34/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_preferred.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (5.94 s)
 (35/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_restrictive.vcpu_auto: WARN: Test passed but there were warnings during execution. Check the log for details. (32.27 s)
 (36/36) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.auto_memory_nodeset_placement.with_iothread.nodeset_undefined.mem_mode_restrictive.vcpu_static: WARN: Test passed but there were warnings during execution. Check the log for details. (6.17 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 16 | SKIP 0 | WARN 18 | INTERRUPT 0 | CANCEL 2
JOB HTML   : /var/lib/avocado/job-results/job-2023-07-19T02.47-0bb0430/results.html
JOB TIME   : 957.75 s

@dzhengfy dzhengfy force-pushed the case_auto_mem_nodeset_placement branch 4 times, most recently from 21a36a7 to 80a2d2a Compare July 25, 2023 07:23
@dzhengfy dzhengfy force-pushed the case_auto_mem_nodeset_placement branch from 80a2d2a to 85b755c Compare July 25, 2023 07:50
@dzhengfy dzhengfy marked this pull request as ready for review July 25, 2023 07:54
@dzhengfy dzhengfy added the depend on The PR has dependency on other PRs label Jul 25, 2023
@dzhengfy dzhengfy requested a review from Yingshun August 8, 2023 07:24
@dzhengfy
Copy link
Contributor Author

dzhengfy commented Aug 8, 2023

@nanli1 could you help review it? thanks

Copy link
Contributor

@Yingshun Yingshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


if vcpu_placement == 'static' and mem_mode == 'none':
xpaths_text = [{'element_attrs': ["./numatune"]}]
if libvirt_vmxml.check_guest_xml_by_xpaths(vmxml, xpaths_text, ignore_status=True):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libvirt_vmxml.check_guest_xml_by_xpaths has only two params , Does the ignore_status=True work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +12 to +14
import json
import os
import re
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json should be the last in this order

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason?

@dzhengfy dzhengfy merged commit 61479e5 into autotest:master Aug 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depend on The PR has dependency on other PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants