guest os booting: add new modular case for direct kernel boot #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
meinaLi
force-pushed
the
direct_kernel
branch
3 times, most recently
from
74fd151
to
e5f3fc3
Compare
meinaLi
force-pushed
the
direct_kernel
branch
3 times, most recently
from
0b87733
to
734de75
Compare
Yingshun
reviewed
Sep 4, 2023
Comment on lines
40
to
43
| direct_kernel_dict = eval(params.get("direct_kernel_dict", "{}") | ||
| % (boot_initrd, boot_vmlinuz)) |
There was a problem hiding this comment.
it will fail if direct_kernel_dict is {}, can you try format()?
There was a problem hiding this comment.
It doesn't work with an error. So here I only removed {} in it.
| :param dest_file: The dest file path | ||
| :param test: Avocado test object | ||
| """ | ||
| if utils_package.package_install("wget"): |
There was a problem hiding this comment.
we recommend installing packages for host in ci
There was a problem hiding this comment.
Yes, we can configure it in jobs.yaml. But for wget package I'm just curious that if we use avocado.utils.download, don't we need to configure it in jobs.yaml, is that right?
| if utils_package.package_install("wget"): | ||
| if url.count("URL"): | ||
| test.cancel("Please provide the url %s" % url) | ||
| download_cmd = "wget %s -O %s" % (url, dest_file) |
There was a problem hiding this comment.
please reuse avocado.utils.download
There was a problem hiding this comment.
I've removed the function download_url in guest_os_booting_base.py and directly use url_download in avocado.utils.download.
meinaLi
force-pushed
the
direct_kernel
branch
from
734de75
to
fd51613
Compare
Yingshun
reviewed
Sep 18, 2023
| vmxml.set_memory(memory_value) | ||
| vmxml.set_current_mem(memory_value) | ||
| vmxml.sync() | ||
| test.log.info("The final guest xml is %s", vmxml) |
There was a problem hiding this comment.
Suggested change
| test.log.info("The final guest xml is %s", vmxml) | |
| test.log.debug("The final guest xml is %s", vmxml) |
Signed-off-by: Meina Li <[email protected]>
meinaLi
force-pushed
the
direct_kernel
branch
from
fd51613
to
3f6c46c
Compare
Yingshun
approved these changes
Sep 18, 2023
chloerh
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly automates:
VIRT-297126 - Boot vm with direct kernel