add case for memory access mode #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanli1
force-pushed
the
add_case_for_memory_access_mode
branch
from
e8912eb
to
4da44cb
Compare
|
modular redesign |
chunfuwen
reviewed
Sep 5, 2023
| against memory backing setting | ||
| """ | ||
|
|
||
| def get_vm_attrs(): |
There was a problem hiding this comment.
can all below functions move outside run, and put ahead to def run() method?
There was a problem hiding this comment.
Thanks chunfu, Updated
Memory access mode Signed-off-by: nanli <[email protected]>
nanli1
force-pushed
the
add_case_for_memory_access_mode
branch
from
4da44cb
to
be39e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nanli [email protected]