Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host_numa_info: add case #5136

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

dzhengfy
Copy link
Contributor

@dzhengfy dzhengfy commented Aug 29, 2023

Case ID: xxx-297812
Test scenarios: Verify numa related info could be achieved by allocating hugepages using supported hugepage size,
check numa information by virsh commands, like capabilities, freepages...

Signed-off-by: Dan Zheng [email protected]

@dzhengfy
Copy link
Contributor Author

(1/1) type_specific.io-github-autotest-libvirt.host_numa.numa_info.default: PASS (45.78 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /var/lib/avocado/job-results/job-2023-09-17T06.53-c5718c7/results.html
JOB TIME : 49.05 s

libvirt-9.5.0

@dzhengfy dzhengfy force-pushed the host_numa_info branch 4 times, most recently from bf997d2 to 9fac762 Compare September 17, 2023 13:25
@dzhengfy dzhengfy marked this pull request as ready for review September 18, 2023 07:18
@dzhengfy
Copy link
Contributor Author

dzhengfy commented Oct 7, 2023

Result on RHEL 8.x

(1/1) type_specific.io-github-autotest-libvirt.host_numa.numa_info.default: WARN: Test passed but there were warnings during execution. Check the log for details. (4.74 s)
RESULTS : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 1 | INTERRUPT 0 | CANCEL 0
JOB HTML : /var/lib/avocado/job-results/job-2023-10-07T01.40-796ba07/results.html
JOB TIME : 5.09 s

(1/1) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_numa_tuning.mem_mode_strict: WARN: Test passed but there were warnings during execution. Check the log for details. (35.16 s)

libvirt-8.0.0

@dzhengfy dzhengfy added the depend on The PR has dependency on other PRs label Oct 7, 2023
@dzhengfy dzhengfy force-pushed the host_numa_info branch 3 times, most recently from 85525fd to 38e4250 Compare October 7, 2023 07:01
@dzhengfy
Copy link
Contributor Author

dzhengfy commented Oct 7, 2023

@hs0210 Could you help check if it can pass on aarch64? Thanks

- default:
allocate_dict = {2048: 200, 1048576: 2}
aarch64:
allocate_dict = {2048: 200, 524288: 4, 16777216: 2}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is enough to test 2M and 512M on kernel 64K machine. 16G is too large to allocate on most machines.

From xxxx-9.3 aarch64 support two serials huge pagesize according to the kernel pagesize.
For xxxx-9 kernel 4K, the supported huge pagesizes are 64K, 2M, 32M, 1G and default to 2M.
For xxxx-9 kernel 64K, the supported huge pagesizes are 2M, 512M, 16G and default to 512M, same with xxxx-8 aarch64.

Please adapt the test cases according to the above info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, 4k will be enabled later. 16G has a problem now. I removed it.

verify_node_mem_by_freepages(test_obj)
verify_node_mem_by_freepages_various_unit(test_obj)
verify_node_distance_by_capabilities(test_obj)
verify_node_cpus_by_capabilities(test_obj)
Copy link
Contributor

@hs0210 hs0210 Oct 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please skip verify_node_cpus_by_capabilities verification for aach64 as aarch64 does not have dies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@dzhengfy
Copy link
Contributor Author

(1/1) type_specific.io-github-autotest-libvirt.host_numa.numa_info.default: PASS (8.69 s)
on arm 8.0.0

Copy link
Contributor

@hs0210 hs0210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aarch64:
allocate_dict = {2048: 200, 524288: 4}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too may blank lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Test scenario: allocate hugepages using supported hugepage size,
check numa information by virsh commands, like capabilities, freepages...

Signed-off-by: Dan Zheng <[email protected]>
@chloerh chloerh merged commit 25df6c7 into autotest:master Dec 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depend on The PR has dependency on other PRs request_test_on_arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants