libvirt-guests: Improve test logging #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitterl
force-pushed
the
improve_guests
branch
from
b662f80
to
a6a7887
Compare
The test sometimes fails and there's no log for the guest service at all. Add checks for start and restart to succeed and if not, log the service logs with journalctl. Also, the Tail was called incorrectly leading to (per default unrecorded) TypeError "can only concatenate str (not "tuple") to str" The Tail already has a log file where it stores the output. Print its path so it can be inspected if needed. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
improve_guests
branch
from
a6a7887
to
4bf6076
Compare
|
dzhengfy
reviewed
Sep 18, 2023
| output_params=(tailed_log_file)) | ||
| tailed_messages = aexpect.Tail(command='tail -f /var/log/messages') | ||
| logging.debug("Tail of log messages are logged in %s", | ||
| tailed_messages.output_filename) |
There was a problem hiding this comment.
Will this output_filename be cleaned after testing automatically?
There was a problem hiding this comment.
Not by default. The file is test specific and created under the tmp basedir https://github.com/avocado-framework/aexpect/blob/main/aexpect/client.py#L145
The way to clean those files would be to call tailed_messages explicitly. We don't do this so we can inspect the file after the test run.
chloerh
approved these changes
Nov 10, 2023
dzhengfy
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test sometimes fails and there's no log for the guest service at all. Add checks for start and restart to succeed and if not, log the service logs with journalctl.
Also, the Tail was called incorrectly leading to (per default unrecorded) TypeError
"can only concatenate str (not "tuple") to str"
The Tail already has a log file where it stores the output. Print its path so it can be inspected if needed.