Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incremental_backup: add timeout before doing the backup. #5187

Merged
merged 1 commit into from
Sep 19, 2023
Merged

incremental_backup: add timeout before doing the backup. #5187

merged 1 commit into from
Sep 19, 2023

Conversation

meinaLi
Copy link
Contributor

@meinaLi meinaLi commented Sep 18, 2023 •
edited
Loading

Sometimes connecting the tls in incremental backup failed with different qemu commands. So here considering two reasons:

  • Do backup operation quickly.
  • The tls server used in tls was used by other jobs/people sometimes.
    So here adding the sleep time to wait for the tls environment perfection to resolve the first reason.

@meinaLi
incremental_backup: add timeout before doing the backup.
b310fa4 
Sometimes connecting the tls in incremental backup failed with different qemu commands.
So here considering add the sleep time to wait for the tls environment
perfection.

Signed-off-by: Meina Li <[email protected]>
@meinaLi meinaLi marked this pull request as draft September 18, 2023 05:43
@meinaLi
Copy link
Contributor Author

meinaLi commented Sep 19, 2023

Run 13 tls auto cases with local host as the tls server in continuously: passed

# avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 incremental_backup..tls_enabled
JOB ID     : 6f6231997c014dee64de6e692c9da0b5db4c13cd
JOB LOG    : /var/lib/avocado/job-results/job-2023-09-19T01.05-6f62319/job.log
 (01/13) type_specific.io-github-autotest-libvirt.incremental_backup.pull_mode.tls_enabled.default_pki_path.verify_client_cert.negative_test.no_client_cert.original_disk_local.coldplug_disk.nbd_tcp.scratch_to_file.not_reuse_scratch_file.custom_exportbitmap.custom_exportname.scratch_not_encrypted: PASS (140.11 s)
 (02/13) type_specific.io-github-autotest-libvirt.incremental_backup.pull_mode.tls_enabled.default_pki_path.verify_client_cert.positive_test.original_disk_local.hotplug_disk.nbd_tcp.scratch_to_file.not_reuse_scratch_file.custom_exportbitmap.custom_exportname.scratch_luks_encrypted: PASS (204.26 s)
 (03/13) type_specific.io-github-autotest-libvirt.incremental_backup.pull_mode.tls_enabled.default_pki_path.verify_client_cert.positive_test.original_disk_local.hotplug_disk.nbd_tcp.scratch_to_file.not_reuse_scratch_file.custom_exportbitmap.custom_exportname.scratch_not_encrypted: PASS (182.21 s)
 (04/13) type_specific.io-github-autotest-libvirt.incremental_backup.pull_mode.tls_enabled.default_pki_path.verify_client_cert.positive_test.original_disk_local.coldplug_disk.nbd_tcp.scratch_to_file.not_reuse_scratch_file.custom_exportbitmap.custom_exportname.scratch_not_encrypted: PASS (180.18 s)
......
 (11/13) type_specific.io-github-autotest-libvirt.incremental_backup.pull_mode.tls_enabled.custom_pki_path.not_verify_client_cert.original_disk_local.hotplug_disk.nbd_tcp.scratch_to_file.not_reuse_scratch_file.custom_exportbitmap.custom_exportname.scratch_luks_encrypted: PASS (190.41 s)
 (12/13) type_specific.io-github-autotest-libvirt.incremental_backup.pull_mode.tls_enabled.custom_pki_path.not_verify_client_cert.original_disk_local.hotplug_disk.nbd_tcp.scratch_to_file.not_reuse_scratch_file.custom_exportbitmap.custom_exportname.scratch_not_encrypted: PASS (165.76 s)
 (13/13) type_specific.io-github-autotest-libvirt.incremental_backup.pull_mode.tls_enabled.custom_pki_path.not_verify_client_cert.original_disk_local.coldplug_disk.nbd_tcp.scratch_to_file.not_reuse_scratch_file.custom_exportbitmap.custom_exportname.scratch_not_encrypted: PASS (166.05 s)
RESULTS    : PASS 13 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2023-09-19T01.05-6f62319/results.html
JOB TIME   : 2319.20 s

@meinaLi meinaLi marked this pull request as ready for review September 19, 2023 07:45
chunfuwen
chunfuwen approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chunfuwen chunfuwen merged commit eddf168 into autotest:master Sep 19, 2023
4 checks passed
@meinaLi meinaLi deleted the tls branch October 9, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunfuwen chunfuwen chunfuwen approved these changes

Assignees
No one assigned
Labels
minorfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meinaLi @chunfuwen