Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtio_rng: Remove redundant code for aarch64 #5190

Merged
merged 1 commit into from
Sep 28, 2023
Merged

virtio_rng: Remove redundant code for aarch64 #5190

merged 1 commit into from
Sep 28, 2023

Conversation

hs0210
Copy link
Contributor

@hs0210 hs0210 commented Sep 18, 2023

After b03e83f, the test provides feeding data on all arches. So remove the aarch64 specific code which is redundant now.

Test Results:

 (1/6) type_specific.io-github-autotest-libvirt.libvirt_rng.backend_udp.bind_connect_mode.hotplug_unplug.positive.no_options: PASS (101.67 s)
 (2/6) type_specific.io-github-autotest-libvirt.libvirt_rng.backend_udp.bind_connect_mode.hotplug_unplug.positive.persistent: PASS (43.01 s)
 (3/6) type_specific.io-github-autotest-libvirt.libvirt_rng.backend_udp.bind_connect_mode.device_assign: PASS (37.98 s)
 (4/6) type_specific.io-github-autotest-libvirt.libvirt_rng.backend_udp.connect_mode.hotplug_unplug.positive.no_options: PASS (43.89 s)
 (5/6) type_specific.io-github-autotest-libvirt.libvirt_rng.backend_udp.connect_mode.hotplug_unplug.positive.persistent: PASS (39.60 s)
 (6/6) type_specific.io-github-autotest-libvirt.libvirt_rng.backend_udp.connect_mode.device_assign: PASS (35.98 s)

@hs0210
virtio_rng: Remove redundant code for aarch64
2f5cab1 
After b03e83f, the test provides feeding data on all arches.
So remove the aarch64 specific code which is redundant now.

Signed-off-by: Hu Shuai <[email protected]>
@hs0210
Copy link
Contributor Author

hs0210 commented Sep 18, 2023

@yanqzhan PTAL.

chunfuwen
chunfuwen approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cliping
cliping approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@cliping cliping left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloerh chloerh merged commit 645ea07 into autotest:master Sep 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunfuwen chunfuwen chunfuwen approved these changes

@chloerh chloerh chloerh approved these changes

@cliping cliping cliping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hs0210 @cliping @chloerh @chunfuwen