Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chardev_pcie: Create USB controller manually for aarch64 #5203

Merged
merged 1 commit into from
Oct 31, 2023
Merged

chardev_pcie: Create USB controller manually for aarch64 #5203

merged 1 commit into from
Oct 31, 2023

Conversation

hs0210
Copy link
Contributor

@hs0210 hs0210 commented Sep 22, 2023 •
edited
Loading

For now, arm can not create USB controller automatically.

When the device_type is controller, all controllers will be deleted, including the USB controller here. However, arm can not create USB controller automatically now. So it will fail to define the guest then.

Before:

ERROR 1-type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.controller.serial.default_start -> LibvirtXMLError: Failed to define avocado-vt-vm1 for reason:
error: Failed to define domain from /tmp/xml_utils_temp_05fpu947.xml
error: unsupported configuration: USB is disabled for this domain, but USB devices are present in the domain XML

After:

PASS 1-type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.controller.serial.default_start

chunfuwen
chunfuwen approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cliping
cliping approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@cliping cliping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yingshun
Copy link
Contributor

@hs0210 Please resolve the conflict, thx!

@hs0210
chardev_pcie: Create USB controller manually for aarch64
315ba50 
For now, arm can not create USB controller automatically.

Signed-off-by: Hu Shuai <[email protected]>
@hs0210
Copy link
Contributor Author

hs0210 commented Oct 23, 2023

@Yingshun Done. PTAL.

@Yingshun Yingshun merged commit 670742a into autotest:master Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yingshun Yingshun Yingshun approved these changes

@chunfuwen chunfuwen chunfuwen approved these changes

@cliping cliping cliping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hs0210 @Yingshun @cliping @chunfuwen