Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtual_network/connectivity: fix test case for s390x #5225

Merged
merged 1 commit into from
Oct 31, 2023
Merged

virtual_network/connectivity: fix test case for s390x #5225

merged 1 commit into from
Oct 31, 2023

Conversation

smitterl
Copy link
Contributor

@smitterl smitterl commented Oct 16, 2023 •
edited
Loading

  1. On s390x, ACPI is not available.
  2. Remove DAC security driver for unprivileged user if present as it
    is not supported for those users.
  3. Allow for configuration of host and guest interface names.

chunfuwen
chunfuwen reviewed Oct 23, 2023
View reviewed changes
libvirt/tests/cfg/virtual_network/connectivity/connectivity_check_bridge_interface.cfg
@@ -50,6 +50,8 @@
iface_attrs_driver = {'driver_attr': {'queues': '4'}}
iface_attrs_model = virtio
iface_attrs_acpi = {'index': '5'}
s390-virtio:
iface_attrs_acpi =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use "no s390-virtio" to filter this case out in s390x?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chunfuwen We could use it, but we want to run the test case on s390x, so let's not filter it out.

@smitterl smitterl marked this pull request as draft October 25, 2023 14:10
@smitterl smitterl marked this pull request as ready for review October 25, 2023 14:47
@smitterl
virtual_network/connectivity: fix test case for s390x
1edb1d9 
1. On s390x, ACPI is not available.
2. Remove DAC security driver for unprivileged user if present as it
is not supported for those users.
3. Allow for configuration of host and guest interface names.

Signed-off-by: Sebastian Mitterle <[email protected]>
@smitterl
Copy link
Contributor Author 

# avocado run --test-runner runner --vt-type libvirt --vt-connect-uri qemu:///system --vt-machine-type s390-virtio virtual_network.connectivity_check.bridge_interface.linux_br,virtual_network.connectivity_check.bridge_interface.unprivileged --vt-extra-params "host_iface = enc2
iface_in_vm = enc1"
No python imaging library installed. Screendump and Windows guest BSOD detection are disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
No python imaging library installed. PPM image conversion to JPEG disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
JOB ID     : 0997697e63e8c714954178fe57016f4173912d99
JOB LOG    : /var/lib/avocado/job-results/job-2023-10-26T04.38-0997697/job.log
 (1/3) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.bridge_interface.unprivileged.default: PASS (51.42 s)
 (2/3) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.bridge_interface.linux_br.default: PASS (100.23 s)
 (3/3) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.bridge_interface.linux_br.multiqueue.nwfilter: PASS (104.77 s)
RESULTS    : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2023-10-26T04.38-0997697/results.html
JOB TIME   : 256.93 s

@smitterl smitterl marked this pull request as draft October 26, 2023 08:46
@smitterl smitterl marked this pull request as ready for review October 26, 2023 10:13
@smitterl
Copy link
Contributor Author

@chloerh Hi could you please help review?

chunfuwen
chunfuwen approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chunfuwen chunfuwen merged commit d32503b into autotest:master Oct 31, 2023
5 checks passed
@smitterl smitterl deleted the connectivity_check branch November 20, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunfuwen chunfuwen chunfuwen approved these changes

@chloerh chloerh chloerh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smitterl @chloerh @chunfuwen