Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add case for guest without memballoon #5232

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
- memory.balloon.no_balloon:
type = guest_without_mem_balloon
start_vm = no
set_mem = 1843200
mem_unit = "KiB"
current_mem_unit = "KiB"
current_mem = "2097152"
mem_value = "2097152"
module = "virtio_balloon"
rm_module = "modprobe -r %s"
check_module = "lsmod |grep %s"
variants:
- virtio_model:
memballoon_model = "virtio"
- virtio_trans_model:
memballoon_model = "virtio-transitional"
- virtio_non_trans_model:
memballoon_model = "virtio-non-transitional"
device_dict = "{'model':'${memballoon_model}'}"
variants:
- memory_allocation:
mem_attrs = {'memory_unit':'${mem_unit}','memory':${mem_value},'current_mem':${current_mem},'current_mem_unit':'${current_mem_unit}'}
expect_xpath = [{'element_attrs':[".//memory[@unit='${mem_unit}']"],'text':'${mem_value}'},{'element_attrs':[".//currentMemory[@unit='${current_mem_unit}']"],'text':'${current_mem}'}]
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#
# Copyright Redhat
#
# SPDX-License-Identifier: GPL-2.0

# Author: Nannan Li<[email protected]>
#
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

from virttest import virsh

from virttest.libvirt_xml import vm_xml
from virttest.libvirt_xml.devices import memballoon
from virttest.utils_libvirt import libvirt_vmxml
from virttest.utils_test import libvirt


def run(test, params, env):
"""
Verify no error msg prompts without guest memory balloon driver.
Scenario:
1.memory balloon models: virtio, virtio-transitional, virtio-non-transitional.
"""

def remove_module(module_name):
"""
Remove specific module.
:params module_name: name of one module.
"""
session = vm.wait_for_login()
status, stdout = session.cmd_status_output(rm_module % module_name)
if status != 0:
test.log.failed("Fail to remove virtio_balloon module:\n%s" % stdout)

status, stdout = session.cmd_status_output(check_module % module_name)
if stdout:
test.fail("virtio_balloon module should be removed: '%s'" % stdout)
session.close()

def run_test():
"""
Define and start guest
Check No error msg prompts without guest memory balloon driver.
"""
test.log.info("TEST_STEP1: Define guest")
vmxml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name)

vmxml.del_device('memballoon', by_tag=True)
mem_balloon = memballoon.Memballoon()
mem_balloon.setup_attrs(**device_dict)
vmxml.devices = vmxml.devices.append(mem_balloon)

vmxml.setup_attrs(**mem_attrs)
vmxml.sync()

test.log.info("TEST_STEP2: Start guest ")
if not vm.is_alive():
vm.start()
vmxml = vm_xml.VMXML.new_from_dumpxml(vm_name)
test.log.debug("After define vm, get vmxml is:\n%s", vmxml)

test.log.info("TEST_STEP3: Remove virtio_balloon module in guest")
remove_module(module)

test.log.info("TEST_STEP4: Change guest current memory allocation")
result = virsh.setmem(domain=vm_name, size=set_mem, debug=True)
libvirt.check_exit_status(result)

test.log.info("TEST_STEP5: Check memory allocation is not changed")
vmxml = vm_xml.VMXML.new_from_dumpxml(vm_name)
libvirt_vmxml.check_guest_xml_by_xpaths(vmxml, expect_xpath)

def teardown_test():
"""
Clean data.
"""
test.log.info("TEST_TEARDOWN: Clean up env.")
bkxml.sync()

vm_name = params.get("main_vm")
vm = env.get_vm(vm_name)
vmxml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name)
bkxml = vmxml.copy()

mem_attrs = eval(params.get("mem_attrs", "{}"))
device_dict = eval(params.get("device_dict", "{}"))
set_mem = int(params.get("set_mem"))
module = params.get("module")
check_module = params.get("check_module")
rm_module = params.get("rm_module")
expect_xpath = eval(params.get("expect_xpath", '{}'))

try:
run_test()

finally:
teardown_test()
Loading