Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration: Add case about destroy vm #5935

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

cliping
Copy link
Contributor

@cliping cliping commented Oct 9, 2024

XXX-298199 - [VM migration][async ops] destroy vm during PerformPhase of migration

@cliping
Copy link
Contributor Author

cliping commented Oct 9, 2024

Test result:

(1/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_dst_vm_before_vm_paused.with_precopy.p2p: STARTED
(1/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_dst_vm_before_vm_paused.with_precopy.p2p: PASS (226.87 s)
(2/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_dst_vm_before_vm_paused.with_precopy.non_p2p: STARTED
(2/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_dst_vm_before_vm_paused.with_precopy.non_p2p: PASS (260.03 s)
(3/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_dst_vm_after_vm_paused.with_precopy.p2p: STARTED
(3/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_dst_vm_after_vm_paused.with_precopy.p2p: PASS (287.88 s)
(4/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_dst_vm_after_vm_paused.with_precopy.non_p2p: STARTED
(4/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_dst_vm_after_vm_paused.with_precopy.non_p2p: PASS (296.75 s)
(5/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_src_vm.with_precopy.p2p: STARTED
(5/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_src_vm.with_precopy.p2p: PASS (310.71 s)
(6/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_src_vm.with_precopy.non_p2p: STARTED
(6/6) type_specific.io-github-autotest-libvirt.migration.async_ops.destroy_vm_during_performphase.destroy_src_vm.with_precopy.non_p2p: PASS (311.12 s)

Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

XXX-298199 - [VM migration][async ops] destroy vm during PerformPhase of
migration

Signed-off-by: lcheng <[email protected]>
@chunfuwen chunfuwen merged commit 8611a4a into autotest:master Oct 23, 2024
5 checks passed

test.log.info("Verify steps.")
if not libvirt.check_vm_state(vm.name, expected_src_state, uri=migration_obj.src_uri):
test.faile("Check vm state on source host fail.")
Copy link
Contributor

@hholoubk hholoubk Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stupid question ... isn't this typo? added "e" at the end of test.faile.
Also the message is not very descriptive.
I would suggest to give more details.

test.fail(f"Check of expected VM state ({expected_src_state}) on source host failed.")

it would be good to to see actual state of the VM .. not sure if it is also listed anywhere around in log.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hholoubk , thanks for pointing this out. I submitted a PR to fix this issue. Please take a look, thanks.

#5958

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to to see actual state of the VM .. not sure if it is also listed anywhere around in log.

I agree. I will submit a PR to avocado-vt to print actual state of the VM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants