guest_os_booting: update tests for s390x #5985
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitterl
force-pushed
the
enable_guest_os_booting_s390x
branch
3 times, most recently
from
42c5da4 to
75582b5
Compare
smitterl
changed the title
smitterl
force-pushed
the
enable_guest_os_booting_s390x
branch
2 times, most recently
from
86b1e55 to
658417c
Compare
smitterl
force-pushed
the
enable_guest_os_booting_s390x
branch
10 times, most recently
from
b007c05 to
12b790b
Compare
The following features are not available on s390x: * SMBIOS * ACPI * fw_cfg * USB * <boot dev.../> * firmware settings * SATA For direct kernel boot, don't use hard coded kernel filename. In our setup we'll use kernel.img, so just use the filename from the download url. Don't use ttyS0, it's the line mode console which is not useful. Using ttysclp0 is the standard on s390x. Cover also s390x-specific parameter @loadparm by allowing generically to run a test command in the booted VM whose output should match an expected regular expression. On s390x, the VM will stop if no bootable medium - such as missing cdrom file - is found. Some tests were written assuming the VM would use the //os/boot element instead of the per-device element by trying to remove only that element. Instead just remove all present boot elements in these cases, no matter where, the test will define the new one that's relevant for the test case. In some boot tests also enable boot for VMs without Secure Boot, where there's no firmware. Add test case that attaches same bootable device twice, this had a bug on s390x recently. s390x currently doesn't have secure boot. Use the first VM and don't set os attributes that relate to secure boot on other archs. Implement logic to actually load into the installer via PXE. Move s390x PXE setup to provider for reuse in boot order tests. Allow for pxelinux.cfg without kickstart, for the boot check we don't need it. Also, a network boot requires more RAM, so update if configured. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
enable_guest_os_booting_s390x
branch
from
12b790b to
23a22ab
Compare
The failing test is a known issue at this point with our current QEMU build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following features are not available on s390x:
<boot dev.../>For direct kernel boot, don't use hard coded kernel filename.
In our setup we'll use kernel.img, so just use the filename
from the download url.
Don't use ttyS0, it's the line mode console which is not useful.
Using ttysclp0 is the standard on s390x.
Cover also s390x-specific parameter @loadparm by allowing generically
to run a test command in the booted VM whose output should match an
expected regular expression.
On s390x, the VM will stop if no bootable medium - such as missing cdrom
file - is found.
Some tests were written assuming the VM would use the //os/boot element
instead of the per-device element by trying to remove only that element.
Instead just remove all present boot elements in these cases, no matter
where, the test will define the new one that's relevant for the test
case.
In some boot tests also enable boot for VMs without Secure Boot, where
there's no firmware.
Add test case that attaches same bootable device twice, this had a bug
on s390x recently.
s390x currently doesn't have secure boot. Use the first VM and don't set
os attributes that relate to secure boot on other archs.
Implement logic to actually load into the installer via PXE.
Move s390x PXE setup to provider for reuse in boot order tests.
Allow for pxelinux.cfg without kickstart, for the boot check we don't
need it.
Also, a network boot requires more RAM, so update if configured.