SRIOV: fix "Login timeout expired" because of 256 vcpus #6084
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yingshun
reviewed
Dec 20, 2024
Comment on lines
27
to
28
| cpu_cmd = "lscpu | grep '^CPU(s):'" | ||
| vcpus_output = process.run(cpu_cmd, shell=True, ignore_status=False).stdout_text |
There was a problem hiding this comment.
What about using avocado.utils.cpu.online_count()? or avocado.utils.cpu.total_count()?
There was a problem hiding this comment.
This is indeed a very good method, I have already updated it. Thanks.
The numbers of guest vcpu is better little than the host vcpus' number. But we don't have this host to match 256 cpus. So after discussing we decided to use the same host cpus' number to test guest vcpus. Signed-off-by: Meina Li <[email protected]>
Yingshun
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numbers of guest vcpu is better little than the host vcpus' number. But we don't have this host to match 256 cpus. So after discussing we decided to use the same host cpus' number to test guest vcpus.