Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtio_fs_group_permission_access: add a new test case #3698

Merged
merged 1 commit into from
Jul 5, 2023
Merged

virtio_fs_group_permission_access: add a new test case #3698

merged 1 commit into from
Jul 5, 2023

Conversation

nickzhq
Copy link
Contributor

@nickzhq nickzhq commented Apr 26, 2023

ID: 2172397

Signed-off-by: Houqi (Nick) Zuo [email protected]

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch 7 times, most recently from 5264f80 to 0fb1af3 Compare April 27, 2023 10:23
@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch 3 times, most recently from 615d575 to 8fa48eb Compare May 8, 2023 02:47
@nickzhq
Copy link
Contributor Author

nickzhq commented May 8, 2023

For linux:
(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtiofs_another_user_access.q35: STARTED
Not opening readers, lock_server_running not locked
(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtiofs_another_user_access.q35: PASS (122.24 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

For windows:
(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtiofs_another_user_access.q35: STARTED
Not opening readers, lock_server_running not locked
(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtiofs_another_user_access.q35: PASS (313.16 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch from 955f726 to b9fb009 Compare May 8, 2023 04:11
@nickzhq
Copy link
Contributor Author

nickzhq commented May 8, 2023

@zhencliu @YongxueHong @xiagao Please take a look, thanks!

@zhencliu
Copy link
Contributor

zhencliu commented May 8, 2023

hi @nickzhq , I found you added two cases with one bz, in which only one polarion case is pasted, so I'm curious do we need another bz(polarion case) to cover one of your new case? Or we cannot make 1 polarion --- 1 auto. cc @xiagao

@nickzhq
Copy link
Contributor Author

nickzhq commented May 8, 2023

hi @nickzhq , I found you added two cases with one bz, in which only one polarion case is pasted, so I'm curious do we need another bz(polarion case) to cover one of your new case? Or we cannot make 1 polarion --- 1 auto. cc @xiagao

Hello @zhencliu , as I known, this case is divided into the different files, therefore, I made 2 commits. So, it's one case instead of two cases.
cc @xiagao

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch 7 times, most recently from bf418e2 to 75721b5 Compare May 8, 2023 12:54
@nickzhq
Copy link
Contributor Author

nickzhq commented May 8, 2023

For windows nfs:
(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.q35: STARTED
Not opening readers, lock_server_running not locked
(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.q35: PASS (296.58 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

For linux nfs:
(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.q35: STARTED
Not opening readers, lock_server_running not locked
(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.q35: PASS (63.48 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch 6 times, most recently from 9796571 to f4be5b5 Compare May 9, 2023 06:55
@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch 2 times, most recently from ce4ebe3 to 42d7d74 Compare May 30, 2023 08:23
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 6, 2023

@zhencliu @xiagao @YongxueHong Please take a look, thanks!

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch from 42d7d74 to 05c68c7 Compare June 14, 2023 09:10
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 14, 2023

@zhencliu @xiagao @YongxueHong Please take a look, thanks!

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch from 05c68c7 to b624417 Compare June 16, 2023 07:47
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 16, 2023

@zhencliu @xiagao @YongxueHong Please take a look, thanks!

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch 2 times, most recently from 698cd8f to 101a4bf Compare June 20, 2023 02:02
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 20, 2023

@xiagao please take a look, thanks!

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch from 101a4bf to cda006b Compare June 20, 2023 06:23
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 20, 2023

@xiagao please take a look, thanks!

@nickzhq
Copy link
Contributor Author

nickzhq commented Jul 3, 2023

@zhencliu @YongxueHong @xiagao Please take a look, thanks!

@YongxueHong
Copy link
Contributor

hi @zhenyzha
Would you like to help to review it, thanks?

@zhencliu
Copy link
Contributor

zhencliu commented Jul 3, 2023

Please make a double check if the copied image is used for vm boot, because we set master_images_clone, if this is not a must, we can remove this setting.

others LGTM

@nickzhq
Copy link
Contributor Author

nickzhq commented Jul 3, 2023

@zhencliu @YongxueHong Done, please take a look again, thanks!

@zhenyzha
Copy link
Contributor

zhenyzha commented Jul 3, 2023

LGTM.Acked-by: Zhenyu Zhang [email protected]

git am 3698.patch
Applying: virtio_fs_group_permission_access: add a new test case

 (1/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.virtio_fs_group_permission_access.default.arm64-pci: STARTED
 (1/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.virtio_fs_group_permission_access.default.arm64-pci: PASS (83.93 s)
 (2/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.arm64-pci: STARTED
 (2/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.arm64-pci: PASS (88.57 s)

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch from cda006b to 4e9babb Compare July 3, 2023 09:17
YongxueHong
YongxueHong approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nickzhq nickzhq force-pushed the diff_user_start_virtiofs_2172397 branch from 4e9babb to 94b78f7 Compare July 4, 2023 07:01
@xiagao
Copy link
Contributor

xiagao commented Jul 5, 2023

(1/4) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.q35: STARTED
(1/4) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.q35: PASS (59.34 s)
(2/4) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.q35: STARTED
(2/4) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.q35: PASS (60.27 s)
(3/4) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.q35: STARTED
(3/4) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.q35: PASS (228.49 s)
(4/4) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.q35: STARTED
(4/4) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_fs_group_permission_access.with_nfs_source.q35: PASS (131.76 s)
ACK

@YongxueHong YongxueHong merged commit 7d045fa into autotest:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiagao xiagao xiagao left review comments

@zhenyzha zhenyzha zhenyzha approved these changes

@zhencliu zhencliu zhencliu approved these changes

@YongxueHong YongxueHong YongxueHong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickzhq @zhencliu @xiagao @YongxueHong @zhenyzha