Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtio_fs_supp_group_transfer: add a new test case #3708

Merged
merged 1 commit into from
Jun 30, 2023
Merged

virtio_fs_supp_group_transfer: add a new test case #3708

merged 1 commit into from
Jun 30, 2023

Conversation

nickzhq
Copy link
Contributor

@nickzhq nickzhq commented May 10, 2023 •
edited
Loading

ID: 2172408
Signed-off-by: Houqi (Nick) Zuo [email protected]

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch 2 times, most recently from 2b33bb1 to bc18617 Compare May 10, 2023 07:11
@nickzhq nickzhq marked this pull request as draft May 10, 2023 07:20
@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch from bc18617 to e3a7255 Compare May 10, 2023 08:27
@nickzhq nickzhq marked this pull request as ready for review May 10, 2023 08:30
@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch 5 times, most recently from f9ad1cd to b096f2c Compare May 11, 2023 01:41
@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch 2 times, most recently from 7b3d4a0 to 5de1d96 Compare May 15, 2023 05:08
@nickzhq
Copy link
Contributor Author

nickzhq commented May 15, 2023 •
edited
Loading

(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_fs_guest_users_allowed_by_group_permission.q35: STARTED
(1/1) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_fs_guest_users_allowed_by_group_permission.q35: PASS (122.61 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch from 5de1d96 to feaf70f Compare May 15, 2023 05:56
@nickzhq
Copy link
Contributor Author

nickzhq commented May 15, 2023

@xiagao @zhencliu please check the patch, thanks!

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch from feaf70f to 6a7360f Compare May 25, 2023 05:38
@nickzhq
Copy link
Contributor Author

nickzhq commented May 25, 2023

@xiagao Please take a look, thanks!

@xiagao
Copy link
Contributor

xiagao commented May 25, 2023

@xiagao Please take a look, thanks!

Also the commit log, thanks.

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch from 6a7360f to cd11a09 Compare May 25, 2023 07:11
@nickzhq nickzhq changed the title virtio_fs_guest_users_allowed_by_group_permission: add a new test case virtio_fs_supp_group_transfer: add a new test case May 25, 2023
@nickzhq
Copy link
Contributor Author

nickzhq commented May 25, 2023

@xiagao Please take a look, thanks!

@xiagao
Copy link
Contributor

xiagao commented May 25, 2023

(1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_supp_group_transfer.q35: STARTED

(1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_supp_group_transfer.q35: PASS (125.78 s)

xiagao
xiagao previously approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@xiagao xiagao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch from d7ba28b to d07facc Compare June 20, 2023 06:26
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 20, 2023

@xiagao please take a look, thanks!

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch from d07facc to 109448e Compare June 21, 2023 03:32
@xiagao
Copy link
Contributor

xiagao commented Jun 21, 2023

(1/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_supp_group_transfer.default.q35: STARTED
(1/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_supp_group_transfer.default.q35: PASS (101.23 s)
(2/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_supp_group_transfer.with_nfs_source.q35: STARTED
(2/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.virtio_fs_supp_group_transfer.with_nfs_source.q35: ERROR: Shell command failed: 'dd if=/dev/urandom of=/mnt/myfs/testdir/virtio_fs_test_file bs=1M count=100 iflag=fullblock' (status: 1, output: "dd: failed to open '/mnt/myfs/testdir/virtio_fs_test_file': Permission denied\n") (100.87 s)
---produce issue.
Ack

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch from 109448e to d6c4e6a Compare June 26, 2023 02:01
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 26, 2023

@zhencliu @xiagao please take a look, thanks!

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch from d6c4e6a to aaa12e6 Compare June 26, 2023 06:39
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 26, 2023

@xiagao please take a look, thanks!

1 similar comment
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 26, 2023

@xiagao please take a look, thanks!

@xiagao
Copy link
Contributor

xiagao commented Jun 26, 2023

@xiagao please take a look, thanks!

It looks good to me. Thanks.

YongxueHong
YongxueHong reviewed Jun 28, 2023
View reviewed changes
qemu/tests/virtio_fs_supp_group_transfer.py Outdated Show resolved Hide resolved
qemu/tests/cfg/virtio_fs_supp_group_transfer.cfg Outdated Show resolved Hide resolved
qemu/tests/virtio_fs_supp_group_transfer.py Outdated Show resolved Hide resolved
qemu/tests/virtio_fs_supp_group_transfer.py Show resolved Hide resolved
@YongxueHong
Copy link
Contributor

Hi, @zhenyzha
Would you like to help review it from the multi-arch perspective?
Thanks.

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch 2 times, most recently from 9621fb9 to 67e70e1 Compare June 28, 2023 06:15
@nickzhq
Copy link
Contributor Author

nickzhq commented Jun 28, 2023

@YongxueHong please take a look, thanks!

YongxueHong
YongxueHong previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nickzhq nickzhq force-pushed the grant_write_access_in_group_permission_2172408 branch from 67e70e1 to 9077bc0 Compare June 29, 2023 01:50
@zhenyzha
Copy link
Contributor

The failure case is a product bug, ack.

git am 3708.patch
Applying: virtio_fs_supp_group_transfer: add a new test case

 (1/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.virtio_fs_supp_group_transfer.arm64-pci: STARTED
 (1/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.virtio_fs_supp_group_transfer.arm64-pci: PASS (50.39 s)
 (2/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.virtio_fs_supp_group_transfer.with_nfs_source.arm64-pci: STARTED
 (2/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.aarch64.page_64k.io-github-autotest-qemu.virtio_fs_supp_group_transfer.with_nfs_source.arm64-pci: ERROR: Shell command failed: 'dd if=/dev/urandom of=/mnt/myfs/testdir/virtio_fs_test_file bs=1M count=100 iflag=fullblock'    (status: 1,    output: "dd: failed to open '/mnt/myfs/testdir/virtio_fs_test_file': Permission denied\n") (48.81 s)

@zhencliu
Copy link
Contributor

LGTM

@YongxueHong YongxueHong merged commit 95466d7 into autotest:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhencliu zhencliu zhencliu left review comments

@xiagao xiagao xiagao approved these changes

@zhenyzha zhenyzha zhenyzha approved these changes

@YongxueHong YongxueHong YongxueHong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickzhq @xiagao @YongxueHong @zhenyzha @zhencliu