watchdog.cfg: support for a 'TCO' watchdog

[yiqianwei]

The Q35 machine type chipset comes with unconditional support for a 'TCO' watchdog

ID: 1462

[yiqianwei]

@yanan-fu and @jingzhao84 , Could you help to review this patch? thanks a lot

[jingzhao84]

@yiqianwei

Check the log and no command of "-global ICH9-LPC.noreboot=false "
Could you double-check it?

Thanks
Jing

[jingzhao84]

@yiqianwei
By the way,
-global ICH9-LPC.noreboot=false
-watchdog-action poweroff
Does it default on libvirt side?

Thanks
Jing

[jingzhao84]

@yiqianwei
How about RHEL 8, should we disable it on RHEL 8?

Thanks
Jing

[yiqianwei]

@yiqianwei By the way, -global ICH9-LPC.noreboot=false -watchdog-action poweroff Does it default on libvirt side?

Thanks Jing
for libvirt-9.3.0-2.el9.x86_64 version, The default command is as follows:
-global ICH9-LPC.noreboot=off
-watchdog-action reset

[jingzhao84]

@yiqianwei By the way, -global ICH9-LPC.noreboot=false -watchdog-action poweroff Does it default on libvirt side?
Thanks Jing
for libvirt-9.3.0-2.el9.x86_64 version, The default command is as follows:
-global ICH9-LPC.noreboot=off
-watchdog-action reset

@yiqianwei
So maybe we need to change the code as well, right?
set the related command line as default when boot guest?

Thanks
Jing

[yiqianwei]

@yiqianwei

Based on these comments, how about RHEL 8, should we disable it on RHEL 8?

Thanks Jing

Hi @jingzhao84 ,

I try it with rhel8.9.0 guest in rhel8.9.0 host, also can work normally.

[yanan-fu]

@yiqianwei Could you update this patch based on the latest change in avocado-vt ? Thanks!

[yiqianwei]

@yanan-fu , please help to review this patch again? thanks

[yanan-fu]

For this watchdog type, does the heartbeat_test need be covered or not ?

[yiqianwei]

For this watchdog type, does the heartbeat_test need be covered or not ?

@yanan-fu, Not need be covered it. Fail to initialized with heartbeat=-1 in dmesg on rhel9.4.0 project.
Developer is also unclear, Anyway, we don't need cover it now. What do you think so ?

dmesg | grep -i itco

1. boot a guest with itco watchdog
   [ 7.070824] iTCO_vendor_support: vendor-support=0
   [ 7.089847] iTCO_wdt iTCO_wdt.1.auto: Found a ICH9 TCO device (Version=2, TCOBASE=0x0660)
   [ 7.090657] iTCO_wdt iTCO_wdt.1.auto: initialized. heartbeat=30 sec (nowayout=0)

2. Remove it and Reload with heartbeat=-1
   [ 117.763343] iTCO_vendor_support: Module Unloaded
   [ 168.237905] iTCO_vendor_support: vendor-support=0

3. fail to heartbeat=-1 sec (nowayout=0), should to heartbeat=30 sec (nowayout=0)
   [ 168.239982] iTCO_wdt iTCO_wdt.1.auto: Found a ICH9 TCO device (Version=2, TCOBASE=0x0660)
   [ 168.240044] iTCO_wdt iTCO_wdt.1.auto: timeout value out of range, using 30
   [ 168.240572] iTCO_wdt iTCO_wdt.1.auto: initialized. heartbeat=-1 sec (nowayout=0)

[jingzhao84]

@yanan-fu
Hello yfu
Based on @yiqianwei 's comments

1. qemu initiative failed
2. dev also have no idea until now
   So I think we can ignore it now and fix it when it can be supported, what do you think?

cc @yiqianwei

Thanks
Jing

[yanan-fu]

@yiqianwei Please update the patch base on our discussion before.

And, suggest do not paste long test result in the patch, thanks!

[yiqianwei]

@yanan-fu ,According to the test steps, only cover watchdog_action test. thanks

[yiqianwei]

@yanan-fu , I have updated it

[yiqianwei]

@yanan-fu , add itco modprobe to watchdog.py. please check this patch again , thanks.
check test log info:
[stdlog] 2023-11-22 00:02:26,942 aexpect.client DEBUG| [10.73.104.156] Sending command: modprobe iTCO_wdt
[stdlog] 2023-11-22 00:02:27,047 aexpect.client DEBUG| [10.73.104.156] Sending command: echo $?
[stdlog] 2023-11-22 00:02:27,149 avocado.test INFO | Context: Checking watchdog load info
[stdlog] 2023-11-22 00:02:27,149 aexpect.client DEBUG| [10.73.104.156] Sending command: lsmod | grep iTCO_wdt
[stdlog] 2023-11-22 00:02:27,256 aexpect.client DEBUG| [10.73.104.156] Sending command: echo $?
[stdlog] 2023-11-22 00:02:27,359 avocado.test INFO | Watchdog device 'itco' add and init successfully
[stdlog] 2023-11-22 00:02:27,359 avocado.test DEBUG| Init info : 'iTCO_wdt 16384 0
[stdlog] iTCO_vendor_support 16384 1 iTCO_wdt
[stdlog] '

[yanan-fu]

Ack