-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fio_perf: add allow_direct_io option for RHEL8.8 and later #3756
Conversation
e73ff6e
to
2b02100
Compare
(01/12) repeat1.Host_RHEL.m8.u9.product_rhel.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.x86_64.io-github-autotest-qemu.fio_perf.shared_fs.virtio_fs_perf.auto.q35: STARTED |
Hi @xiagao Please @ someone to review this PR or mark it as draft.Thanks! |
@leidwang pls help to review,thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@vivianQizhu Call for your review, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would need to append versions later if add it this way. Let's define it by virtiofsd versions.
For rhel8, virtiofsd binary is provided by qemu-kvm. |
qemu/tests/cfg/fio_perf.cfg
Outdated
@@ -94,10 +94,12 @@ | |||
fio_options = "--rw=%s --bs=%s --iodepth=%s --runtime=1m --direct=1 --filename=${fs_dest}/%s --name=job1 --ioengine=libaio --thread --group_reporting --numjobs=%s --size=512MB --time_based --output=${guest_result_file} &> /dev/null" | |||
order_list = "Block_size Iodepth Threads BW(MB/S) IOPS Latency(ms) Host_CPU BW/CPU KVM_Exits" | |||
fs_binary_extra_options = " --thread-pool-size=32" | |||
!Host_RHEL.m8: | |||
# The below option isn't supported on RHEL8. | |||
Host_RHEL.m9: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line would need update later. So this is not the best solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get your point.
Change it with !Host_RHEL.m8:
Thanks.
9b26156
to
e5544e9
Compare
fs_binary_extra_options += " --allow-direct-io" | ||
vfsd_ver_chk_cmd = "rpm -q virtiofsd" | ||
Host_RHEL.m8: | ||
no Host_RHEL.m8.u2 Host_RHEL.m8.u3 Host_RHEL.m8.u4 Host_RHEL.m8.u5 Host_RHEL.m8.u6 Host_RHEL.m8.u7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Host_RHEL.m8.u0 and Host_RHEL.m8.u1 also support allow_direct_io
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls check the L89.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, got it.
From RHEL8.8, virtiofsd support allow_direct_io option. Signed-off-by: Xiaoling Gao <[email protected]>
@vivianQizhu Could you help review it again, thanks. |
ID: 2217203
From RHEL8.8, virtiofsd support allow_direct_io option.