Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fio_perf: add allow_direct_io option for RHEL8.8 and later #3756

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

xiagao
Copy link
Contributor

@xiagao xiagao commented Jun 25, 2023

ID: 2217203
From RHEL8.8, virtiofsd support allow_direct_io option.

@xiagao xiagao force-pushed the bz2217203-fio branch 2 times, most recently from e73ff6e to 2b02100 Compare June 25, 2023 03:02
@xiagao
Copy link
Contributor Author

xiagao commented Jun 25, 2023

(01/12) repeat1.Host_RHEL.m8.u9.product_rhel.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.x86_64.io-github-autotest-qemu.fio_perf.shared_fs.virtio_fs_perf.auto.q35: STARTED
(01/12) repeat1.Host_RHEL.m8.u9.product_rhel.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.9.0.x86_64.io-github-autotest-qemu.fio_perf.shared_fs.virtio_fs_perf.auto.q35: PASS (1865.83 s)

@leidwang
Copy link
Contributor

leidwang commented Jul 5, 2023

Hi @xiagao Please @ someone to review this PR or mark it as draft.Thanks!

@xiagao
Copy link
Contributor Author

xiagao commented Jul 6, 2023

@leidwang pls help to review,thanks.

Copy link
Contributor

@leidwang leidwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xiagao
Copy link
Contributor Author

xiagao commented Jul 6, 2023

@vivianQizhu Call for your review, thanks.

Copy link
Contributor

@vivianQizhu vivianQizhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to append versions later if add it this way. Let's define it by virtiofsd versions.

@xiagao
Copy link
Contributor Author

xiagao commented Jul 31, 2023

You would need to append versions later if add it this way. Let's define it by virtiofsd versions.

For rhel8, virtiofsd binary is provided by qemu-kvm.
And I set no rhel8.x, does it need to append version later?

@@ -94,10 +94,12 @@
fio_options = "--rw=%s --bs=%s --iodepth=%s --runtime=1m --direct=1 --filename=${fs_dest}/%s --name=job1 --ioengine=libaio --thread --group_reporting --numjobs=%s --size=512MB --time_based --output=${guest_result_file} &> /dev/null"
order_list = "Block_size Iodepth Threads BW(MB/S) IOPS Latency(ms) Host_CPU BW/CPU KVM_Exits"
fs_binary_extra_options = " --thread-pool-size=32"
!Host_RHEL.m8:
# The below option isn't supported on RHEL8.
Host_RHEL.m9:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line would need update later. So this is not the best solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get your point.
Change it with !Host_RHEL.m8:
Thanks.

@xiagao xiagao force-pushed the bz2217203-fio branch 2 times, most recently from 9b26156 to e5544e9 Compare August 2, 2023 09:27
fs_binary_extra_options += " --allow-direct-io"
vfsd_ver_chk_cmd = "rpm -q virtiofsd"
Host_RHEL.m8:
no Host_RHEL.m8.u2 Host_RHEL.m8.u3 Host_RHEL.m8.u4 Host_RHEL.m8.u5 Host_RHEL.m8.u6 Host_RHEL.m8.u7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Host_RHEL.m8.u0 and Host_RHEL.m8.u1 also support allow_direct_io ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check the L89.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, got it.

From RHEL8.8, virtiofsd support allow_direct_io option.

Signed-off-by: Xiaoling Gao <[email protected]>
@xiagao
Copy link
Contributor Author

xiagao commented Aug 17, 2023

@vivianQizhu Could you help review it again, thanks.

@vivianQizhu vivianQizhu merged commit 3707f2e into autotest:master Aug 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants